This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9522

phab-refresh: do not pick draft changeset from the bare "default" branch
ClosedPublic

Authored by marmoute on Dec 5 2020, 6:13 AM.

Details

Reviewers
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG024f90fc01b5: phab-refresh: do not pick draft changeset from the bare "default" branch
Summary

My initial test overlooked a common case: draft changeset on the default branch.
So right now, heptapod is doing a final refresh of the patch with the landed
version. This is not a bit problem except for the extra noise. However we would
be better without the noise.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Dec 5 2020, 6:13 AM
marmoute updated this revision to Diff 24047.Dec 5 2020, 6:08 PM

initial sent before test run (refresh post test run imminent)

mharbison72 accepted this revision.Dec 5 2020, 8:40 PM
This revision is now accepted and ready to land.Dec 5 2020, 8:40 PM

Revision Contents
Changeset List

PathPackages
Mcontrib/phab-refresh-stack.sh (12 lines)

Diff 24047

contrib/phab-refresh-stack.sh

#!/bin/bash #!/bin/bash
set -eu set -eu
revision_in_stack=`hg log --rev '.#stack and ::.' -T '\nONE-REV\n' | grep 'ONE-REV' | wc -l` revision_in_stack=`hg log \
revision_on_phab=`hg log --rev '.#stack and ::. and desc("re:\nDifferential Revision: [^\n]+D\d+$")' -T '\nONE-REV\n' | grep 'ONE-REV' | wc -l` --rev '.#stack and ::. and topic()' \
-T '\nONE-REV\n' \
| grep 'ONE-REV' | wc -l`
revision_on_phab=`hg log \
--rev '.#stack and ::. and topic() and desc("re:\nDifferential Revision: [^\n]+D\d+$")'\
-T '\nONE-REV\n' \
| grep 'ONE-REV' | wc -l`
if [[ $revision_in_stack -eq 0 ]]; then if [[ $revision_in_stack -eq 0 ]]; then
echo "stack is empty" >&2 echo "stack is empty" >&2
exit 0 exit 0
fi fi
if [[ $revision_on_phab -eq 0 ]]; then if [[ $revision_on_phab -eq 0 ]]; then
echo "no tracked diff in this stack" >&2 echo "no tracked diff in this stack" >&2
hg \ hg \
--config extensions.phabricator= \ --config extensions.phabricator= \
--config phabricator.url=https://phab.mercurial-scm.org/ \ --config phabricator.url=https://phab.mercurial-scm.org/ \
--config phabricator.callsign=HG \ --config phabricator.callsign=HG \
--config auth.phabricator.schemes=https \ --config auth.phabricator.schemes=https \
--config auth.phabricator.prefix=phab.mercurial-scm.org \ --config auth.phabricator.prefix=phab.mercurial-scm.org \
--config auth.phabricator.phabtoken=$PHABRICATOR_TOKEN \ --config auth.phabricator.phabtoken=$PHABRICATOR_TOKEN \
phabsend --rev '.#stack and ::.' phabsend --rev '.#stack and ::. and topic()' \