Page MenuHomePhabricator

share: remove unexpected heading from "verbose" container in help test
ClosedPublic

Authored by martinvonz on Dec 9 2020, 12:59 PM.

Details

Summary

test-gendoc-*.t have been failing for me since 91425656e2b1 (share:
add documentation about share-safe mode in hg help -e share,
2020-11-27) with this kind of output:

--- /usr/local/google/home/martinvonz/hg/tests/test-gendoc-ru.t
+++ /usr/local/google/home/martinvonz/hg/tests/test-gendoc-ru.t.err
@@ -2,3 +2,9 @@

   $ $TESTDIR/check-gendoc ru
   checking for parse errors
+  gendoc.txt:12818: (SEVERE/4) Unexpected section title.
+
+  Sharing requirements and configs of source repository with shares
+  -----------------------------------------------------------------
+  Exiting due to level-4 (SEVERE) system message.
+  [1]

This patch fixes that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Dec 9 2020, 12:59 PM
mharbison72 accepted this revision.Dec 9 2020, 7:24 PM
mharbison72 added a subscriber: mharbison72.

Well, this is new:

$ hg phabimport 9552
applying patch from D9552
unable to find 'usr/local/google/home/martinvonz/hg/tests/test-gendoc-ru.t' for patching
(use '--prefix' to apply patch relative to the current directory)
abort: patch failed to apply

It looks like maybe the hg parser isn't smart enough to skip ahead to the first filename reference. I edited the patch to indent the triple backtick content, and apply it.

This revision is now accepted and ready to land.Dec 9 2020, 7:24 PM

Well, this is new:

$ hg phabimport 9552
applying patch from D9552
unable to find 'usr/local/google/home/martinvonz/hg/tests/test-gendoc-ru.t' for patching
(use '--prefix' to apply patch relative to the current directory)
abort: patch failed to apply

It looks like maybe the hg parser isn't smart enough to skip ahead to the first filename reference. I edited the patch to indent the triple backtick content, and apply it.

Yes, I knew about that. I'm sorry I didn't think of it myself. Thanks for fixing!