Page MenuHomePhabricator

debugcommands: introduce command to upgrade/downgrade shares
Changes PlannedPublic

Authored by pulkit on Dec 12 2020, 5:46 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

In past few months, we have developed functionality to share requirements and
configs of share-source and a way to upgrade repository from old format to
share-safe format using debugupgraderepo command.

However there is still no way to upgrade the shares as debugupgraderepo does
not support upgrading that.

Having share-safe rolled out in existing setup is quite important and hence we
need a way to upgrade existing shares once share-source upgrades.

This patch introduces a new debug command debugsharesafe which can be used to
upgrade or downgrade shares.

Functionality to upgrade shares to use the new method is the last thing left in
the whole work.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Dec 12 2020, 5:46 AM

should we simply teach hg debugupgraderepo to do this type of upgrade on shares? I am not comfortable with adding new updata/downgradfe command for specific requirements as it would become a jungle quite quickly.

should we simply teach hg debugupgraderepo to do this type of upgrade on shares? I am not comfortable with adding new updata/downgradfe command for specific requirements as it would become a jungle quite quickly.

hg debugupgraderepo does not support upgrading shares. It will require some good amount of work to have hg debugupgraderepo support shares and hence I didn't go that way.

should we simply teach hg debugupgraderepo to do this type of upgrade on shares? I am not comfortable with adding new updata/downgradfe command for specific requirements as it would become a jungle quite quickly.

hg debugupgraderepo does not support upgrading shares. It will require some good amount of work to have hg debugupgraderepo support shares and hence I didn't go that way.

Do you think we could we have this as some early branching in debugupgraderepo ?

baymax updated this revision to Diff 24610.Jan 6 2021, 6:53 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit planned changes to this revision.Jan 6 2021, 7:12 AM