This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9599

localrepo: delete obsolete comment about `prefix in repo` raising exception
ClosedPublic

Authored by martinvonz on Dec 14 2020, 2:53 PM.

Download Raw Diff

Details

Reviewers

mharbison72

Group Reviewers

hg-reviewers

Commits

rHGc6ae1982b2a1: localrepo: delete obsolete comment about `prefix in repo` raising exception

Summary

We dropped support for prefix in repo, where prefix is a hex
prefix, in 8b86acc7aa64 (context: drop support for looking up context
by ambiguous changeid (API), 2018-04-28), after having deprecated it a
while before that. These days you get a ProgrammingError instead if
you pass in a short nodeid.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

martinvonz created this revision.Dec 14 2020, 2:53 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptDec 14 2020, 2:53 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

martinvonz added a child revision: D9600: errors: raise InputError if an ambiguous revision id prefix is used.Dec 14 2020, 4:31 PM

mharbison72 accepted this revision.Dec 15 2020, 10:59 PM

This revision is now accepted and ready to land.Dec 15 2020, 10:59 PM

martinvonz added a commit: rHGc6ae1982b2a1: localrepo: delete obsolete comment about `prefix in repo` raising exception.Dec 15 2020, 11:32 PM

Closed by commit rHGc6ae1982b2a1: localrepo: delete obsolete comment about `prefix in repo` raising exception (authored by martinvonz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/localrepo.py (6 lines)

Commit	Parents	Author	Summary	Date
c143c6931b2b	d6afa9c149c3	Martin von Zweigbergk		Dec 10 2020, 4:18 AM

Status	Author	Revision
Closed	martinvonz	D9390 errors: introduce SecurityError and use it in a few places
Closed	martinvonz	D9389 errors: raise InputError when too few arguments given to alias
Closed	martinvonz	D9388 errors: raise InputError on bad top-level flags
Closed	martinvonz	D9393 errors: raise StateError on uncommitted changes when merge starts
Closed	martinvonz	D9392 errors: raise StateError when there are unresolves merge conflicts
Closed	martinvonz	D9602 errors: raise InputError on recursive template definition
Closed	martinvonz	D9391 errors: raise StateError when push fails because it creates new heads
Closed	martinvonz	D9387 errors: raise InputError on early parse error in dispatch
Closed	martinvonz	D9386 errors: raise more specifc errors from narrowcommands
Closed	martinvonz	D9601 errors: use detailed exit code 50 for StorageError
Closed	martinvonz	D9600 errors: raise InputError if an ambiguous revision id prefix is used
Closed	martinvonz	D9599 localrepo: delete obsolete comment about `prefix in repo` raising exception

Diff 24265

mercurial/localrepo.py

	except (IndexError, LookupError):			except (IndexError, LookupError):
	raise error.RepoLookupError(			raise error.RepoLookupError(
	_(b"unknown revision '%s'") % pycompat.bytestr(changeid)			_(b"unknown revision '%s'") % pycompat.bytestr(changeid)
	)			)
	except error.WdirUnsupported:			except error.WdirUnsupported:
	return context.workingctx(self)			return context.workingctx(self)

	def __contains__(self, changeid):			def __contains__(self, changeid):
	"""True if the given changeid exists			"""True if the given changeid exists"""

	error.AmbiguousPrefixLookupError is raised if an ambiguous node
	specified.
	"""
	try:			try:
	self[changeid]			self[changeid]
	return True			return True
	except error.RepoLookupError:			except error.RepoLookupError:
	return False			return False

	def __nonzero__(self):			def __nonzero__(self):
	return True			return True

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	24265		Dec 14 2020, 2:53 PM	★	★
Diff 2	24290	rHGc6ae1982b2a1271bc8cbdd7b0f1d6f13bd39aae5	Dec 10 2020, 4:18 AM	★	★