This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9605

hook: set `HGPLAIN=1` for external hooks
ClosedPublic

Authored by mharbison72 on Dec 14 2020, 7:37 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8fa87bce4929: hook: set `HGPLAIN=1` for external hooks
Summary

External hooks will probably turn around and run hg commands, so this seems like
a reasonable convenience for people who miss it in the documentation.

There are no test changes because printenv.py filters out anything without a
"HG_" prefix. It wouldn't be a useful test anyway, because this is already
inherited from the test environment.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 14 2020, 7:37 PM
pulkit accepted this revision.Dec 17 2020, 5:53 AM
pulkit added a subscriber: pulkit.

Probably we should mention about in relnotes?

This revision is now accepted and ready to land.Dec 17 2020, 5:53 AM
mharbison72 added a commit: rHG8fa87bce4929: hook: set `HGPLAIN=1` for external hooks.Dec 17 2020, 6:57 AM
Closed by commit rHG8fa87bce4929: hook: set `HGPLAIN=1` for external hooks (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.
mharbison72 added a comment.Dec 17 2020, 1:38 PM
In D9605#144815, @pulkit wrote:

Probably we should mention about in relnotes?

Oops, I meant to do that. Added in D9629.

Revision Contents
Changeset List

PathPackages
Mmercurial/hook.py (1 line)

Diff 24334

mercurial/hook.py

# make in-memory changes visible to external process # make in-memory changes visible to external process
if repo is not None: if repo is not None:
tr = repo.currenttransaction() tr = repo.currenttransaction()
repo.dirstate.write(tr) repo.dirstate.write(tr)
if tr and tr.writepending(): if tr and tr.writepending():
env[b'HG_PENDING'] = repo.root env[b'HG_PENDING'] = repo.root
env[b'HG_HOOKTYPE'] = htype env[b'HG_HOOKTYPE'] = htype
env[b'HG_HOOKNAME'] = name env[b'HG_HOOKNAME'] = name
env[b'HGPLAIN'] = b'1'
for k, v in pycompat.iteritems(args): for k, v in pycompat.iteritems(args):
# transaction changes can accumulate MBs of data, so skip it # transaction changes can accumulate MBs of data, so skip it
# for external hooks # for external hooks
if k == b'changes': if k == b'changes':
continue continue
if callable(v): if callable(v):
v = v() v = v()