This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9736

persistent-nodemap: highlight that node is not sent when streaming
ClosedPublic

Authored by marmoute on Jan 12 2021, 5:40 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG40ec2173f4dd: persistent-nodemap: highlight that node is not sent when streaming
rHG666fc4b65946: persistent-nodemap: highlight that node is not sent when streaming

Summary

We have a local work-around, however having that data sent in the first place
would be better. So we start with a test that monitor what is sent, and notice
they are not.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 12 2021, 5:40 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJan 12 2021, 5:40 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D9748: upgrade: explicitly test for revlog index.Jan 13 2021, 7:10 AM

marmoute added a commit: rHG666fc4b65946: persistent-nodemap: highlight that node is not sent when streaming.Jan 13 2021, 2:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG666fc4b65946: persistent-nodemap: highlight that node is not sent when streaming (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

marmoute added a commit: rHG40ec2173f4dd: persistent-nodemap: highlight that node is not sent when streaming.Jan 15 2021, 12:01 AM

Revision Contents
Changeset List

			Path	Packages
M			tests/test-persistent-nodemap.t (6 lines)

Status	Author	Revision
Closed	marmoute	D9749 persistent-nodemap: also list related file as part of the store
Closed	marmoute	D9748 upgrade: explicitly test for revlog index
Closed	marmoute	D9736 persistent-nodemap: highlight that node is not sent when streaming
Closed	marmoute	D9735 clone: make sure we warm the cache after a clone
Closed	marmoute	D9734 persistent-nodemap: test it (does not) exist after a stream clone
Closed	marmoute	D9733 persistent-nodemap: test it (does not) exist after a local clone
Closed	marmoute	D9732 persistent-nodemap: test that is it present after a clone
Closed	marmoute	D9731 narrow: overwrite readfast in excludeddirmanifestctx
Closed	marmoute	D9730 test: replace a many occurence of `python` with `$PYTHON`

Diff 24811

tests/test-persistent-nodemap.t

	data-unused: 0			data-unused: 0
	data-unused: 0.000%			data-unused: 0.000%

	stream clone			stream clone
	------------			------------

	The persistent nodemap should exist after a streaming clone			The persistent nodemap should exist after a streaming clone

	$ hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone --quiet			$ hg clone -U --stream --config ui.ssh="\"$PYTHON\" \"$TESTDIR/dummyssh\"" ssh://user@dummy/test-repo stream-clone --debug \| egrep '00(changelog\|manifest)'
				adding [s] 00manifest.i (313 KB)
				adding [s] 00manifest.d (452 KB)
				adding [s] 00changelog.i (313 KB)
				adding [s] 00changelog.d (360 KB)
	$ ls -1 stream-clone/.hg/store/ \| egrep '00(changelog\|manifest)(\.n\|-.*\.nd)'			$ ls -1 stream-clone/.hg/store/ \| egrep '00(changelog\|manifest)(\.n\|-.*\.nd)'
	00changelog-*.nd (glob)			00changelog-*.nd (glob)
	00changelog.n			00changelog.n
	00manifest-*.nd (glob)			00manifest-*.nd (glob)
	00manifest.n			00manifest.n
	$ hg -R stream-clone debugnodemap --metadata			$ hg -R stream-clone debugnodemap --metadata
	uid: * (glob)			uid: * (glob)
	tip-rev: 5005			tip-rev: 5005
	tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe			tip-node: 90d5d3ba2fc47db50f712570487cb261a68c8ffe
	data-length: 121088			data-length: 121088
	data-unused: 0			data-unused: 0
	data-unused: 0.000%			data-unused: 0.000%

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	24730		Jan 12 2021, 5:40 PM	★	★
Diff 2	24811	rHG666fc4b65946bd260dc9ff2dd75f8ec247684398	Jan 12 2021, 1:47 PM	★	★