This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9731

narrow: overwrite readfast in excludeddirmanifestctx
ClosedPublic

Authored by marmoute on Jan 12 2021, 5:40 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa3ccbac659d8: narrow: overwrite readfast in excludeddirmanifestctx
Summary

The excludeddirmanifestctx does not have underlying storage (because it is
excluded) so the implementation of the readfast trying to access it crash.
This was reveled while running some cache warning code on narrow repositories.
That code will be introduced further down in the series.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 12 2021, 5:40 PM
pulkit accepted this revision.Jan 13 2021, 4:59 AM
This revision is now accepted and ready to land.Jan 13 2021, 4:59 AM
marmoute added a commit: rHGa3ccbac659d8: narrow: overwrite readfast in excludeddirmanifestctx.Jan 13 2021, 2:41 PM
Closed by commit rHGa3ccbac659d8: narrow: overwrite readfast in excludeddirmanifestctx (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/manifest.py (4 lines)

Diff 24806

mercurial/manifest.py

def __init__(self, dir, node): def __init__(self, dir, node):
self._dir = dir self._dir = dir
self._node = node self._node = node
def read(self): def read(self):
return excludeddir(self._dir, self._node) return excludeddir(self._dir, self._node)
def readfast(self, shallow=False):
# special version of readfast since we don't have underlying storage
return self.read()
def write(self, *args): def write(self, *args):
raise error.ProgrammingError( raise error.ProgrammingError(
b'attempt to write manifest from excluded dir %s' % self._dir b'attempt to write manifest from excluded dir %s' % self._dir
) )
class excludedmanifestrevlog(manifestrevlog): class excludedmanifestrevlog(manifestrevlog):
"""Stand-in for excluded treemanifest revlogs. """Stand-in for excluded treemanifest revlogs.