This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	martinvonz	D9744 shelve: move listshelves() to new ShelfDir class, so caller need not pass vfs
Closed	martinvonz	D9743 shelve: also create class representing whole directory of shelves
Closed	martinvonz	D9742 shelve: add a method for deleting shelf to new shelf class
Closed	martinvonz	D9741 shelve: inline ".patch" constant now that it's only used in the Shelf class
Closed	martinvonz	D9740 shelve: use listshelves() in cleanupoldbackups()
Closed	martinvonz	D9739 shelve: make listshelves() list shelves in a given vfs
Closed	martinvonz	D9738 shelve: replace repo instance in Shelf class by vfs instance
Closed	martinvonz	D9737 shelve: use listdir() instead of readdir() when we don't need stat information
Closed	martinvonz	D9720 shelve: don't crash on file with unexpected extension in .hg/shelved/
Closed	martinvonz	D9719 shelve: don't include invalid shelves in `hg shelve --list`
Closed	martinvonz	D9714 shelve: extract some repeated creation of shelf instances to variables
Closed	martinvonz	D9713 shelve: teach new shelf class to check if .shelve file exists
Closed	martinvonz	D9712 shelve: move method for creating backup to new shelf class
Closed	martinvonz	D9711 shelve: make gennames() helper generate relative backup paths
Closed	martinvonz	D9710 shelve: use listshelves() in cleanup function
Closed	martinvonz	D9709 shelve: inline shelvedfile.filename() since there are no callers outside class
Closed	martinvonz	D9708 shelve: make listshelves() return shelf names instead of filenames
Closed	martinvonz	D9707 shelve: move method for getting stat (mtime) to new shelf class
Closed	martinvonz	D9706 shelve: open patch using new shelf class instead of open()
Closed	martinvonz	D9705 shelve: move function for opening .patch file to new shelf class
Closed	martinvonz	D9704 shelve: move method for reading .hg to new shelf class
Closed	martinvonz	D9703 shelve: move method for writing bundle to new shelf class
Closed	martinvonz	D9702 shelve: move method for reading .shelve file to new shelf class
Closed	martinvonz	D9701 shelve: move method for writing .shelve to new shelf class
Closed	martinvonz	D9700 shelve: introduce class representing a shelf
Closed	martinvonz	D9699 shelve: raise more specific errors
Closed	martinvonz	D9698 shelve: trust caller of shelvedfile.opener() to check that the file exists
Closed	martinvonz	D9697 shelve: rewrite check for unknown shelf to delete
Closed	martinvonz	D9696 shelve: remove a bundlerepo method
Closed	martinvonz	D9718 tests: add tests for corrupt .hg/shelved/ directory

Diff 24956

mercurial/shelve.py

	from .utils import (			from .utils import (
	dateutil,			dateutil,
	stringutil,			stringutil,
	)			)

	backupdir = b'shelve-backup'			backupdir = b'shelve-backup'
	shelvedir = b'shelved'			shelvedir = b'shelved'
	shelvefileextensions = [b'hg', b'patch', b'shelve']			shelvefileextensions = [b'hg', b'patch', b'shelve']
	# universal extension is present in all types of shelves
	patchextension = b'patch'

	# we never need the user, so we use a			# we never need the user, so we use a
	# generic user for all shelve operations			# generic user for all shelve operations
	shelveuser = b'shelve@localhost'			shelveuser = b'shelve@localhost'


	class Shelf(object):			class Shelf(object):
	"""Represents a shelf, including possibly multiple files storing it.			"""Represents a shelf, including possibly multiple files storing it.

	Old shelves will have a .patch and a .hg file. Newer shelves will			Old shelves will have a .patch and a .hg file. Newer shelves will
	also have a .shelve file. This class abstracts away some of the			also have a .shelve file. This class abstracts away some of the
	differences and lets you work with the shelf as a whole.			differences and lets you work with the shelf as a whole.
	"""			"""

	def __init__(self, vfs, name):			def __init__(self, vfs, name):
	self.vfs = vfs			self.vfs = vfs
	self.name = name			self.name = name

	@staticmethod			@staticmethod
	def open(repo, name):			def open(repo, name):
	return Shelf(vfsmod.vfs(repo.vfs.join(shelvedir)), name)			return Shelf(vfsmod.vfs(repo.vfs.join(shelvedir)), name)

	def exists(self):			def exists(self):
	return self.vfs.exists(			return self.vfs.exists(self.name + b'.patch') and self.vfs.exists(
	self.name + b'.' + patchextension			self.name + b'.hg'
	) and self.vfs.exists(self.name + b'.hg')			)

	def mtime(self):			def mtime(self):
	return self.vfs.stat(self.name + b'.' + patchextension)[stat.ST_MTIME]			return self.vfs.stat(self.name + b'.patch')[stat.ST_MTIME]

	def writeinfo(self, info):			def writeinfo(self, info):
	scmutil.simplekeyvaluefile(self.vfs, self.name + b'.shelve').write(info)			scmutil.simplekeyvaluefile(self.vfs, self.name + b'.shelve').write(info)

	def hasinfo(self):			def hasinfo(self):
	return self.vfs.exists(self.name + b'.shelve')			return self.vfs.exists(self.name + b'.shelve')

	def readinfo(self):			def readinfo(self):

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	24744		Jan 12 2021, 5:48 PM	★	★
Diff 2	24956	rHG4d5119d00a2affa4d740272696afad416c4e94d8	Jan 11 2021, 1:53 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

shelve: inline ".patch" constant now that it's only used in the Shelf classClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24956

mercurial/shelve.py

shelve: inline ".patch" constant now that it's only used in the Shelf class
ClosedPublic

Revision Contents
Changeset List