This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9815

run-tests: work around the Windows firewall popup for server processes
ClosedPublic

Authored by mharbison72 on Jan 18 2021, 1:45 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3e23794b9e1c: run-tests: work around the Windows firewall popup for server processes
Summary

Windows doesn't have a python3 executable, so cc0b332ab9fc attempted to work
around the issue by copying the current python to python3.exe. That put it in
_tmpbindir because of failures in test-run-tests.t when using _bindir,
which looked like a process was trying to open it to write out a copy while it
was in use. (Interestingly, I couldn't reproduce this running the test by
itself in a loop for a couple of hours, but it happens constantly when running
all tests.) The problem with using _tmpbindir is that it is the randomly
generated path for the test run, and instead of Windows Firewall remembering the
executable signature or image hash when allowing the process to open a server
port, it apparently remembers the image path. That means every run will trigger
a popup to allow it, which is bad for firing off a test run and walking away.

I tried to symlink to the python executable, but that currently requires admin
priviledges[1]. This will prompt the first time if the underlying python binary
has never opened a server port, but appears to avoid it on subsequent runs.

[1] https://bugs.python.org/issue40687

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
M.hgignore (1 line)
Mtests/run-tests.py (13 lines)

Diff 25112

.hgignore

.\#* .\#*
tests/artifacts/cache/big-file-churn.hg tests/artifacts/cache/big-file-churn.hg
tests/.coverage* tests/.coverage*
tests/.testtimes* tests/.testtimes*
tests/.hypothesis tests/.hypothesis
tests/hypothesis-generated tests/hypothesis-generated
tests/annotated tests/annotated
tests/exceptions tests/exceptions
tests/python3
tests/*.err tests/*.err
tests/htmlcov tests/htmlcov
build build
contrib/chg/chg contrib/chg/chg
contrib/hgsh/hgsh contrib/hgsh/hgsh
contrib/vagrant/.vagrant contrib/vagrant/.vagrant
dist dist
packages packages

tests/run-tests.py

os.symlink(sysexecutable, mypython) os.symlink(sysexecutable, mypython)
self._createdfiles.append(mypython) self._createdfiles.append(mypython)
except OSError as err: except OSError as err:
# child processes may race, which is harmless # child processes may race, which is harmless
if err.errno != errno.EEXIST: if err.errno != errno.EEXIST:
raise raise
else: else:
# Windows doesn't have `python3.exe`, and MSYS cannot understand the # Windows doesn't have `python3.exe`, and MSYS cannot understand the
# reparse point with that name provided by Microsoft. Copy the # reparse point with that name provided by Microsoft. Create a
# current interpreter to PATH with that name so the shebang lines # simple script on PATH with that name that delegates to the py3
# work. # launcher so the shebang lines work.
if os.getenv('MSYSTEM'): if os.getenv('MSYSTEM'):
shutil.copy( with open(osenvironb[b'RUNTESTDIR'] + b'/python3', 'wb') as f:
sys.executable, f.write(b'#!/bin/sh\n')
_bytes2sys(self._tmpbindir + b'/python3.exe'), f.write(b'py -3 "$@"\n')
)
exedir, exename = os.path.split(sysexecutable) exedir, exename = os.path.split(sysexecutable)
vlog( vlog(
"# Modifying search path to find %s as %s in '%s'" "# Modifying search path to find %s as %s in '%s'"
% (exename, pyexename, exedir) % (exename, pyexename, exedir)
) )
path = os.environ['PATH'].split(os.pathsep) path = os.environ['PATH'].split(os.pathsep)
while exedir in path: while exedir in path: