This is an archive of the discontinued Mercurial Phabricator instance.

purge: also deal with directory with --confirm
ClosedPublic

Authored by marmoute on Jan 18 2021, 4:26 AM.

Details

Summary

Getting the exact number is simple (you have to project the result of previous
deletion to detect super-directory with only about-to-be-deleted content). So we
use a vaguer message.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 18 2021, 4:26 AM
Alphare added inline comments.
mercurial/merge.py
2389–2401

This case is not mutually exclusive with the others, is it?

marmoute added inline comments.Jan 22 2021, 9:35 AM
mercurial/merge.py
2389–2401

the case is not, but the message is.

Alphare added inline comments.Jan 22 2021, 11:01 AM
mercurial/merge.py
2389–2401

Sure, but I think I would like to know about the empty directories in the other cases.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

(discovering an unsubmitted message from the stone age)

mercurial/merge.py
2389–2401

Yeah but that is a whole different level of computation, since we have to computed the "would be deleted" directory in an entirely new manner.