This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9821

sqlitestore: disable test with chg
ClosedPublic

Authored by joerg.sonnenberger on Jan 18 2021, 8:00 AM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHG9c35267f01e0: sqlitestore: disable test with chg
Summary

There are known issues with transactions not being closed in a timely
fashion, making the test flakey.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute requested changes to this revision.Jan 18 2021, 8:25 AM
marmoute added a subscriber: marmoute.

Can you add a small in place comment to explain the requirements ?

This revision now requires changes to proceed.Jan 18 2021, 8:25 AM
marmoute accepted this revision.Jan 18 2021, 8:35 AM

Great, thanks.

pulkit accepted this revision.Jan 18 2021, 8:48 AM
This revision is now accepted and ready to land.Jan 18 2021, 8:48 AM
joerg.sonnenberger added a commit: rHG9c35267f01e0: sqlitestore: disable test with chg.Jan 18 2021, 9:38 AM
Closed by commit rHG9c35267f01e0: sqlitestore: disable test with chg (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-sqlitestore.t (7 lines)

Diff 25110

tests/test-sqlitestore.t

#require sqlite #require sqlite no-chg
The sqlitestore backend leaves transactions around when used with chg.
Since this backend is primarily intended as proof-of-concept for
alternative storage backends, disable it for chg test runs to avoid
the instability.
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF
> [extensions] > [extensions]
> sqlitestore = > sqlitestore =
> EOF > EOF
New repo should not use SQLite by default New repo should not use SQLite by default