This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9831

exchangev2: avoid second look-up by node
ClosedPublic

Authored by joerg.sonnenberger on Jan 18 2021, 6:51 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG009130064813: exchangev2: avoid second look-up by node
Summary

Accessing the revlog by node is slightly more expensive than by
revision, so look up the revision first and use it afterwards.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/exchangev2.py (5 lines)

Diff 25189

mercurial/exchangev2.py

return len(cl) return len(cl)
def ondupchangeset(cl, node): def ondupchangeset(cl, node):
added.append(node) added.append(node)
def onchangeset(cl, node): def onchangeset(cl, node):
progress.increment() progress.increment()
revision = cl.changelogrevision(node) rev = cl.rev(node)
revision = cl.changelogrevision(rev)
added.append(node) added.append(node)
# We need to preserve the mapping of changelog revision to node # We need to preserve the mapping of changelog revision to node
# so we can set the linkrev accordingly when manifests are added. # so we can set the linkrev accordingly when manifests are added.
manifestnodes[cl.rev(node)] = revision.manifest manifestnodes[rev] = revision.manifest
nodesbyphase = {phase: set() for phase in phases.phasenames.values()} nodesbyphase = {phase: set() for phase in phases.phasenames.values()}
remotebookmarks = {} remotebookmarks = {}
# addgroup() expects a 7-tuple describing revisions. This normalizes # addgroup() expects a 7-tuple describing revisions. This normalizes
# the wire data to that format. # the wire data to that format.
# #
# This loop also aggregates non-revision metadata, such as phase # This loop also aggregates non-revision metadata, such as phase