This is an archive of the discontinued Mercurial Phabricator instance.

tests: skip a detailed exit status in test-lfs-test-server
ClosedPublic

Authored by mharbison72 on Jan 20 2021, 12:42 AM.

Details

Summary

The mode of failure here differs between lfs-test-server and hg serve, and
they each throw a different exception. The hg serve case raises a subclass of
StorageError, which gets a detailed status. The lfs-test-server case raises
a subclass of Abort, which does not. Since the exit code isn't currently
conditionizable in the tests, this is the simplest way to avoid the failure.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 20 2021, 12:42 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

Should this go on stable instead to make the test fixed on stable too?

Should this go on stable instead to make the test fixed on stable too?

Yes