This is an archive of the discontinued Mercurial Phabricator instance.

Differential D993

hiddenoverride: add a test demonstrating a visibility issue
ClosedPublic

Authored by quark on Oct 9 2017, 8:22 PM.
Tags
None
Subscribers
durham

Details

Reviewers
durham
Group Reviewers
Restricted Project
Commits
rFBHGXb79ad548db40: hiddenoverride: add a test demonstrating an visibility issue
Summary

The last uncommit should make B invisible. This is from a user report.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Oct 9 2017, 8:22 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 9 2017, 8:22 PM
quark retitled this revision from hiddenoverride: add a test demonstrating an visibility issue to hiddenoverride: add a test demonstrating a visibility issue.Oct 19 2017, 1:38 PM
durham accepted this revision.Oct 31 2017, 12:21 PM
durham added a subscriber: durham.
durham added inline comments.
tests/test-fbamend-hiddenoverride.t
190

You are currently inside a repository. We should cd out before init'ing a new one

This revision is now accepted and ready to land.Oct 31 2017, 12:21 PM
quark added inline comments.Nov 1 2017, 2:39 PM
tests/test-fbamend-hiddenoverride.t
190

It uses $TESTTMP absolute path so we don't have to cd out. I found it pretty inconvenient for checking whether we need cd .. or not so I used $TESTTMP everywhere in my test code.

Closed by commit rFBHGXb79ad548db40: hiddenoverride: add a test demonstrating an visibility issue (authored by quark). · Explain WhyNov 2 2017, 3:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-fbamend-hiddenoverride.t (48 lines)

Diff 3215

tests/test-fbamend-hiddenoverride.t

$ hg bookmark -d book-e $ hg bookmark -d book-e
$ hg log -G -T '{rev} {desc} {bookmarks}\n' $ hg log -G -T '{rev} {desc} {bookmarks}\n'
o 3 C o 3 C
| |
o 1 B o 1 B
| |
o 0 A o 0 A
Uncommit and hiddenoverride. This is uncommon but the last uncommit should make
"A" invisible:
$ cat >> $HGRCPATH <<EOF
> [extensions]
> uncommit =
> EOF
$ hg init $TESTTMP/repo2
durhamUnsubmitted
Not Done

You are currently inside a repository. We should cd out before init'ing a new one

durham: You are currently inside a repository. We should cd out before init'ing a new one
quarkAuthorUnsubmitted
Not Done

It uses $TESTTMP absolute path so we don't have to cd out. I found it pretty inconvenient for checking whether we need cd .. or not so I used $TESTTMP everywhere in my test code.

quark: It uses `$TESTTMP` absolute path so we don't have to cd out. I found it pretty inconvenient for…
$ cd $TESTTMP/repo2
$ hg debugdrawdag <<'EOS'
> B
> |
> A
> |
> Z
> EOS
$ eval `hg tags -T '{tag}={node}\n'`
$ rm .hg/localtags
$ hg up $A
2 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg uncommit
$ hg log -T '{desc}' -G
o B
|
x A
|
@ Z
$ hg up -C $B
2 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg uncommit
$ hg log -T '{desc}' -G
@ A
|
o Z
$ hg up -C .
0 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ hg uncommit
$ hg log -T '{desc}' -G
x A
|
@ Z