This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9931

engine: 'if not, else' -> 'if, else'
ClosedPublic

Authored by pulkit on Jan 31 2021, 2:35 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG45c3a263d5d1: engine: 'if not, else' -> 'if, else'
Summary

I personally feel that

if x:
    pass
else:
    pass

is easier to read and edit than

if not x:
    pass
else:
    pass

Next patches will add one more if-else clause.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jan 31 2021, 2:35 PM
pulkit added a commit: rHG45c3a263d5d1: engine: 'if not, else' -> 'if, else'.Feb 2 2021, 1:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG45c3a263d5d1: engine: 'if not, else' -> 'if, else' (authored by pulkit). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade_utils/engine.py (8 lines)

Diff 25398

mercurial/upgrade_utils/engine.py

ui.status( ui.status(
_( _(
b'(it is safe to interrupt this process any time before ' b'(it is safe to interrupt this process any time before '
b'data migration completes)\n' b'data migration completes)\n'
) )
) )
if not upgrade_op.requirements_only: if upgrade_op.requirements_only:
ui.status(_(b'upgrading repository requirements\n'))
scmutil.writereporequirements(srcrepo, upgrade_op.new_requirements)
else:
with dstrepo.transaction(b'upgrade') as tr: with dstrepo.transaction(b'upgrade') as tr:
_clonerevlogs( _clonerevlogs(
ui, ui,
srcrepo, srcrepo,
dstrepo, dstrepo,
tr, tr,
upgrade_op, upgrade_op,
) )
scmutil.writereporequirements(srcrepo, upgrade_op.new_requirements) scmutil.writereporequirements(srcrepo, upgrade_op.new_requirements)
if upgrade_op.backup_store: if upgrade_op.backup_store:
# The lock file from the old store won't be removed because nothing has a # The lock file from the old store won't be removed because nothing has a
# reference to its new location. So clean it up manually. Alternatively, we # reference to its new location. So clean it up manually. Alternatively, we
# could update srcrepo.svfs and other variables to point to the new # could update srcrepo.svfs and other variables to point to the new
# location. This is simpler. # location. This is simpler.
backupvfs.unlink(b'store/lock') backupvfs.unlink(b'store/lock')
else:
ui.status(_(b'upgrading repository requirements\n'))
scmutil.writereporequirements(srcrepo, upgrade_op.new_requirements)
return backuppath return backuppath