Page MenuHomePhabricator

build: fake PEP440 versions

Authored by joerg.sonnenberger on Thu, Feb 4, 5:19 PM.



If the current version is not exactly a tag, use a local version
specifier to fix it up. PEP 440 uses the "+" separator and only allows
alphanumeric and dot, so use dot for further separations.

Old devel build: 5.7+155-a163cc36d06b
New devel build: 5.7+hg155.a163cc36d06b

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joerg.sonnenberger edited the summary of this revision. (Show Details)Fri, Feb 12, 9:22 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.

This patch broke test-check-format.t because these three lines fits on one line. I'll fix it in flight, but please check your setup.

martinvonz added inline comments.Tue, Feb 23, 2:00 AM

I don't know what the "hg" string above (line 422) signifies, but should it be here too?

Also, it seems that the code at needs to be updated. Our Windows build failed because of that, so that's how I noticed. I'll probably send a patch tomorrow.

martinvonz added inline comments.Tue, Feb 23, 12:04 PM

Also, were the added .s in before %(latesttagdistance)s here intentional? If so, why?