Page MenuHomePhabricator

rhg: add limited support for the `config` sub-command
ClosedPublic

Authored by SimonSapin on Mon, Feb 8, 5:44 PM.

Details

Summary

Only with one argument and no flag. This is mostly for testing.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Mon, Feb 8, 5:44 PM
Alphare added a subscriber: Alphare.Tue, Feb 9, 4:33 AM

It looks like you've recorded copy information about rust/rhg/src/commands/root.rs and rust/rhg/src/commands/config.rs. Was that on purpose?

rust/hg-core/src/utils.rs
121

I was going to suggest putting this here in the previous patch. :)

Yes, when typing that hg cp command I thought that this copy record isn’t wrong since that’s indeed how the new file started. Is there a reason to prefer *not* having that recorded as a copy?

Alphare accepted this revision.Tue, Feb 9, 3:36 PM

Yes, when typing that hg cp command I thought that this copy record isn’t wrong since that’s indeed how the new file started. Is there a reason to prefer *not* having that recorded as a copy?

No, I was simply wondering if maybe your IDE had done that for you behind your back (that has happened to me at first).

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.