This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9975

tweak-default: no longer enable the experimental return code
ClosedPublic

Authored by marmoute on Feb 10 2021, 2:01 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG839cacdff919: tweak-default: no longer enable the experimental return code
Summary

The change is quite new and undocumented (since it is experimental) so it seems
premature to make it available in tweak default. In addition, I am not sure the
new return code are frozen yet (eg: some of the initial feedback have not been
incorporated). Before the release I doubled check (probably with Martin) that
they were not enabled by default and got replied that they were only enabled in
the tests. Have I been aware that they have been also enabled in tweak default I
would I have lobbied to delay that.

I discovered they were in tweak default from users feedback. They found it an
unpleasant and unexpected surprise of 5.7.

So I suggest we no enable enable this experimental feature for Mercurial 5.7 and
revisit this later, when the feature will be more mature.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Feb 10 2021, 2:01 PM
marmoute added a comment.Feb 10 2021, 2:28 PM

⚠ This is intended for stable ⚠

martinvonz accepted this revision.Feb 10 2021, 2:58 PM
martinvonz added a subscriber: martinvonz.

I agree. My commit message in 21733e8c doesn't mention changing tweakdefaults, so I wonder if I added that by mistake. I remember also being surprised myself that we had started rolling out the change internally before I thought we had (we have tweakdefaults enabled). Sorry that I didn't think of it then that maybe it shouldn't have been in there.

This revision is now accepted and ready to land.Feb 10 2021, 2:58 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (2 lines)

Diff 25533

mercurial/ui.py

# for use with str.translate(None, _keepalnum), to keep just alphanumerics # for use with str.translate(None, _keepalnum), to keep just alphanumerics
_keepalnum = b''.join( _keepalnum = b''.join(
c for c in map(pycompat.bytechr, range(256)) if not c.isalnum() c for c in map(pycompat.bytechr, range(256)) if not c.isalnum()
) )
# The config knobs that will be altered (if unset) by ui.tweakdefaults. # The config knobs that will be altered (if unset) by ui.tweakdefaults.
tweakrc = b""" tweakrc = b"""
[ui] [ui]
# Gives detailed exit codes for input/user errors, config errors, etc.
detailed-exit-code = True
# The rollback command is dangerous. As a rule, don't use it. # The rollback command is dangerous. As a rule, don't use it.
rollback = False rollback = False
# Make `hg status` report copy information # Make `hg status` report copy information
statuscopies = yes statuscopies = yes
# Prefer curses UIs when available. Revert to plain-text with `text`. # Prefer curses UIs when available. Revert to plain-text with `text`.
interface = curses interface = curses
# Make compatible commands emit cwd-relative paths by default. # Make compatible commands emit cwd-relative paths by default.
relative-paths = yes relative-paths = yes