This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9979

hooks: add some test about HGPLAIN setting and hooks
ClosedPublic

Authored by marmoute on Feb 10 2021, 6:47 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG0760282995cf: hooks: add some test about HGPLAIN setting and hooks
rHG9524dc7ce217: hooks: add some test about HGPLAIN setting and hooks

Summary

In Mercurial 5.7, hooks are now ran with HGPLAIN set, which is a behavior change
in. I could not find explicit test about it so I am adding one. The next
changesets will introduce more change to help user mitigate the behavior change
when needed.

Diff Detail

Repository

rHG Mercurial

Branch

stable

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

marmoute created this revision.Feb 10 2021, 6:47 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptFeb 10 2021, 6:47 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D9980: procutil: add a way to unset and environment variable.Feb 10 2021, 6:47 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax added a child revision: D9981: hooks: introduce a `:run-with-plain` option for hooks.Feb 11 2021, 5:25 AM

marmoute added a commit: rHG9524dc7ce217: hooks: add some test about HGPLAIN setting and hooks.Feb 11 2021, 11:34 AM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG9524dc7ce217: hooks: add some test about HGPLAIN setting and hooks (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

marmoute added a commit: rHG0760282995cf: hooks: add some test about HGPLAIN setting and hooks.Feb 12 2021, 12:04 AM

Revision Contents
Changeset List

			Path	Packages
M			tests/test-hook.t (27 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	25537		Feb 10 2021, 6:47 PM	★	★
Diff 2	25541		Feb 10 2021, 8:10 PM	★	★
Diff 3	25550	rHG9524dc7ce21755f510b18462c37da5101b12ca2e	Feb 10 2021, 4:43 PM	★	★

Commit	Parents	Author	Summary	Date
95171eb0ef8d	4a91ba7b4eb5	Pierre-Yves David		Feb 10 2021, 4:43 PM

Status	Author	Revision
Closed	marmoute	D9982 hooks: add a `auto` value for `hooks.*run-with-plain`
Closed	marmoute	D9981 hooks: introduce a `:run-with-plain` option for hooks
Abandoned	marmoute	D9980 procutil: add a way to unset and environment variable
Closed	marmoute	D9979 hooks: add some test about HGPLAIN setting and hooks
Closed	marmoute	D9978 hooks: forbid ':' in hook name

Diff 25541

tests/test-hook.t

	[255]			[255]
	$ hg log			$ hg log
	changeset: 0:3903775176ed			changeset: 0:3903775176ed
	tag: tip			tag: tip
	user: test			user: test
	date: Thu Jan 01 00:00:00 1970 +0000			date: Thu Jan 01 00:00:00 1970 +0000
	summary: a			summary: a


				unsetup the test
				----------------

				# touch the file to unconfuse chg with a diffrent mtime
				$ sleep 1
				$ touch $TESTTMP/untrusted.py
				$ cat << EOF >> $HGRCPATH
				> [extensions]
				> untrusted=!
				> EOF

				HGPLAIN setting in hooks
				========================

				$ cat << EOF >> .hg/hgrc
				> [hooks]
				> pre-version.testing-default=echo '### default ###' plain: \$HGPLAIN
				> EOF

				$ (unset HGPLAIN; hg version --quiet)
				### default ### plain: 1
				Mercurial Distributed SCM (*) (glob)

				$ HGPLAIN=1 hg version --quiet
				### default ### plain: 1
				Mercurial Distributed SCM (*) (glob)