( )⚙ D9997 remotefilelog: rework workaround for sshpeer deadlocks

This is an archive of the discontinued Mercurial Phabricator instance.

remotefilelog: rework workaround for sshpeer deadlocks
ClosedPublic

Authored by valentin.gatienbaron on Feb 15 2021, 4:42 PM.

Details

Summary

The wrapping of sshpeer.cleanup silently broke when cleanup was
renamed to _cleanup, a couple of years ago.

I don't know what orig.im_self is, but regardless, the intention of
the wrapping seems pretty clear: close stderr before
sshpeer._cleanuppipes blocks on it. So do that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.