Page MenuHomePhabricator

sshpeer: enable+fix warning about sshpeers not being closed explicitly
ClosedPublic

Authored by valentin.gatienbaron on Feb 15 2021, 4:42 PM.

Details

Summary

I recommend looking at this with a diff that ignores indentation.

The test changes are because localrepo.close() updates some cache,
which appears happens earlier now on rollbacks or strips or something.

The http changes are because httppeer.close() prints stats with
--verbose.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

This break a handful of tests. I'll send a fix shortly.

fix available as D10152 and D10153