This is an archive of the discontinued Mercurial Phabricator instance.

rust: Upgrade Cargo.lock to the newer format
ClosedPublic

Authored by SimonSapin on Mar 2 2021, 3:58 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Mar 2 2021, 3:58 AM
Alphare accepted this revision.Mar 2 2021, 3:59 AM

This should probably go to the stable branch though

pulkit added a subscriber: pulkit.Mar 10 2021, 4:08 AM

Is it fine if I go ahead and push this to default branch?

Please do. This change has no impact on end users, it only helps contributors who add, remove, or update a dependency in Cargo.toml files while using a recent Rust toolchain that defaults to doing this upgrade for any change to Cargo.lock. In the stable branch I think there is no need to backport this patch manually, waiting for the next merge from default is fine.

I suppose backporting this would make it easier to backport other patches that touch Cargo.lock and are based on this one, if that turns out to be needed.

However this patch does not apply cleanly on stable. I can submit another one for that separately, but I don’t know how well they’ll merge together.

pulkit accepted this revision.Mar 10 2021, 1:34 PM
This revision is now accepted and ready to land.Mar 10 2021, 1:34 PM
This revision was automatically updated to reflect the committed changes.