( )⚙ D10098 rhg: Fall back to Python on unsupported `rhg config <section>`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10098

rhg: Fall back to Python on unsupported `rhg config <section>`
ClosedPublic

Authored by SimonSapin on Mar 3 2021, 1:24 PM.

Details

Reviewers
Alphare
marmoute
Group Reviewers
hg-reviewers
Commits
rHG92e3cfd63096: rhg: Fall back to Python on unsupported `rhg config <section>`
Summary

Printing an entire section (as opposed to a single value with
rhg config foo.bar) is not supported yet in Rust only.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.Mar 3 2021, 1:24 PM
baymax updated this revision to Diff 26072.Mar 4 2021, 8:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Mar 5 2021, 3:48 AM
marmoute accepted this revision.Mar 9 2021, 1:02 PM
SimonSapin edited the summary of this revision. (Show Details)Mar 12 2021, 5:06 PM
SimonSapin added a commit: rHG92e3cfd63096: rhg: Fall back to Python on unsupported `rhg config <section>`.Mar 16 2021, 5:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG92e3cfd63096: rhg: Fall back to Python on unsupported `rhg config <section>` (authored by SimonSapin). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/rhg/src/commands/config.rs (2 lines)

Diff 26072

rust/rhg/src/commands/config.rs

pub fn run(invocation: &crate::CliInvocation) -> Result<(), CommandError> { pub fn run(invocation: &crate::CliInvocation) -> Result<(), CommandError> {
let (section, name) = invocation let (section, name) = invocation
.subcommand_args .subcommand_args
.value_of("name") .value_of("name")
.expect("missing required CLI argument") .expect("missing required CLI argument")
.as_bytes() .as_bytes()
.split_2(b'.') .split_2(b'.')
.ok_or_else(|| HgError::abort(""))?; .ok_or_else(|| HgError::unsupported("hg config <section>"))?;
let value = invocation.config.get(section, name).unwrap_or(b""); let value = invocation.config.get(section, name).unwrap_or(b"");
invocation.ui.write_stdout(&format_bytes!(b"{}\n", value))?; invocation.ui.write_stdout(&format_bytes!(b"{}\n", value))?;
Ok(()) Ok(())
} }