( )⚙ D10099 rhg: Align "malformed --config" error message with Python

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10099

rhg: Align "malformed --config" error message with Python
ClosedPublic

Authored by SimonSapin on Mar 3 2021, 1:24 PM.

Details

Reviewers
Alphare
marmoute
Group Reviewers
hg-reviewers
Commits
rHG28a54c128e82: rhg: Align "malformed --config" error message with Python
Summary

Differences in error message formatting can cause tests to fail.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.Mar 3 2021, 1:24 PM
baymax updated this revision to Diff 26073.Mar 4 2021, 8:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Mar 5 2021, 3:48 AM
marmoute accepted this revision.Mar 9 2021, 1:02 PM
SimonSapin edited the summary of this revision. (Show Details)Mar 12 2021, 5:06 PM
SimonSapin added a commit: rHG28a54c128e82: rhg: Align "malformed --config" error message with Python.Mar 16 2021, 5:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG28a54c128e82: rhg: Align "malformed --config" error message with Python (authored by SimonSapin). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/config/layer.rs (2 lines)

Diff 26035

rust/hg-core/src/config/layer.rs

let mut layer = Self::new(ConfigOrigin::CommandLine); let mut layer = Self::new(ConfigOrigin::CommandLine);
for arg in cli_config_args { for arg in cli_config_args {
let arg = arg.as_ref(); let arg = arg.as_ref();
if let Some((section, item, value)) = parse_one(arg) { if let Some((section, item, value)) = parse_one(arg) {
layer.add(section, item, value, None); layer.add(section, item, value, None);
} else { } else {
Err(HgError::abort(format!( Err(HgError::abort(format!(
"malformed --config option: \"{}\" \ "malformed --config option: '{}' \
(use --config section.name=value)", (use --config section.name=value)",
String::from_utf8_lossy(arg), String::from_utf8_lossy(arg),
)))? )))?
} }
} }
if layer.sections.is_empty() { if layer.sections.is_empty() {
Ok(None) Ok(None)
} else { } else {