( )⚙ D10136 tests: clarify some missing output in test-merge-subrepos

This is an archive of the discontinued Mercurial Phabricator instance.

tests: clarify some missing output in test-merge-subrepos
ClosedPublic

Authored by SimonSapin on Mar 9 2021, 4:40 AM.

Details

Summary

This makes the test behavior clearer, especially, why the output are
inconsistent.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Mar 9 2021, 4:40 AM
baymax updated this revision to Diff 26195.Mar 9 2021, 8:40 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

I would approve this if I did not wrote it myself :-D

Alphare requested changes to this revision.Mar 10 2021, 3:48 AM
Alphare added a subscriber: Alphare.

In status semantics, deleted is the same as missing, and you've listed them as removed. I think this is the correct output, but the comment is confusing.

This revision now requires changes to proceed.Mar 10 2021, 3:48 AM

In status semantics, deleted is the same as missing, and you've listed them as removed. I think this is the correct output, but the comment is confusing.

The test itself is confusing because the update seems to upgrade the initially missing file to removed. This is fairly strange but not the core issue here. So when this eventually get fixed, I expect the fixer to sort the missing/deleted situation themself.

Alphare accepted this revision.Mar 12 2021, 11:52 AM
This revision now requires review to proceed.Mar 12 2021, 11:52 AM
baymax updated this revision to Diff 26342.Mar 15 2021, 9:10 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.