( )⚙ D10145 rhg: Return an error code for `rhg config Section.idontexist`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10145

rhg: Return an error code for `rhg config Section.idontexist`
ClosedPublic

Authored by SimonSapin on Mar 9 2021, 4:41 AM.

Details

Reviewers
marmoute
Alphare
Group Reviewers
hg-reviewers
Commits
rHGb1e6265e8336: rhg: Return an error code for `rhg config Section.idontexist`
Summary

This is what Python-based hg does.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.Mar 9 2021, 4:41 AM
baymax updated this revision to Diff 26204.Mar 9 2021, 8:41 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute accepted this revision.Mar 9 2021, 1:27 PM
Alphare accepted this revision.Mar 10 2021, 4:26 AM
baymax updated this revision to Diff 26351.Mar 15 2021, 9:10 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

SimonSapin added a commit: rHGb1e6265e8336: rhg: Return an error code for `rhg config Section.idontexist`.Mar 16 2021, 5:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGb1e6265e8336: rhg: Return an error code for `rhg config Section.idontexist` (authored by SimonSapin). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/rhg/src/commands/config.rs (10 lines)

Diff 26351

rust/rhg/src/commands/config.rs

let (section, name) = invocation let (section, name) = invocation
.subcommand_args .subcommand_args
.value_of("name") .value_of("name")
.expect("missing required CLI argument") .expect("missing required CLI argument")
.as_bytes() .as_bytes()
.split_2(b'.') .split_2(b'.')
.ok_or_else(|| HgError::unsupported("hg config <section>"))?; .ok_or_else(|| HgError::unsupported("hg config <section>"))?;
let value = invocation.config.get(section, name).unwrap_or(b""); if let Some(value) = invocation.config.get(section, name) {
invocation.ui.write_stdout(&format_bytes!(b"{}\n", value))?; invocation.ui.write_stdout(&format_bytes!(b"{}\n", value))?;
Ok(()) Ok(())
} else {
Err(CommandError::Unsuccessful)
}
} }