( )⚙ D10156 hg: make `clean` return consistent with the `update` function

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10156

hg: make `clean` return consistent with the `update` function
ClosedPublic

Authored by marmoute on Mar 11 2021, 11:52 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGaf7535249ea9: hg: make `clean` return consistent with the `update` function
Summary

The function return a boolean and is used as such. Lets be explicit about it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Mar 11 2021, 11:52 AM
Alphare accepted this revision.Mar 16 2021, 5:34 AM
marmoute added a commit: rHGaf7535249ea9: hg: make `clean` return consistent with the `update` function.Mar 16 2021, 5:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGaf7535249ea9: hg: make `clean` return consistent with the `update` function (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hg.py (1 line)

Diff 26442

mercurial/hg.py

def clean(repo, node, show_stats=True, quietempty=False): def clean(repo, node, show_stats=True, quietempty=False):
"""forcibly switch the working directory to node, clobbering changes""" """forcibly switch the working directory to node, clobbering changes"""
stats = mergemod.clean_update(repo[node]) stats = mergemod.clean_update(repo[node])
assert stats.unresolvedcount == 0 assert stats.unresolvedcount == 0
if show_stats: if show_stats:
_showstats(repo, stats, quietempty) _showstats(repo, stats, quietempty)
return False
# naming conflict in updatetotally() # naming conflict in updatetotally()
_clean = clean _clean = clean
_VALID_UPDATECHECKS = { _VALID_UPDATECHECKS = {
mergemod.UPDATECHECK_ABORT, mergemod.UPDATECHECK_ABORT,
mergemod.UPDATECHECK_NONE, mergemod.UPDATECHECK_NONE,