Page MenuHomePhabricator

mail: convert SMTPException to bytes before passing to error.Abort()
ClosedPublic

Authored by mharbison72 on Mar 12 2021, 1:08 PM.

Details

Summary

Caught by pytype:

File "/mnt/c/Users/Matt/hg/mercurial/mail.py", line 168, in _smtp: Function Abort.__init__ was called with the wrong arguments [wrong-arg-types]
         Expected: (self, message: Union[bytearray, bytes, memoryview], ...)
  Actually passed: (self, message: smtplib.SMTPException)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.