This is an archive of the discontinued Mercurial Phabricator instance.

FTR, this stack was built up on default, on top of D7296, D7384, and D7295, as well as a list of exclusions that I added as each run failed. But these seem good for stable, and I didn't want to hold it up to land that stuff.

pulkit accepted this revision.Mar 12 2021, 1:12 PM

This revision is now accepted and ready to land.Mar 12 2021, 1:12 PM

mharbison72 added a commit: rHG6595e22048fe: typing: fix a suppression directive that was mangled by black formatting.Mar 17 2021, 6:10 AM

Closed by commit rHG6595e22048fe: typing: fix a suppression directive that was mangled by black formatting (authored by mharbison72). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/posix.py (7 lines)

Status	Author	Revision
Closed	mharbison72	D10215 typing: rewrite a conditional assignment to unconfuse pytype
Closed	mharbison72	D10214 typing: add assertions to localrepo.py to appease pytype
Closed	mharbison72	D10213 obsutil: maintain a homogenous list when computing successors
Closed	mharbison72	D10212 typing: add an assertion to verify.py to appease pytype
Closed	mharbison72	D10211 typing: add an assertion to mercurial/hgweb/webcommands.py to help pytype
Closed	mharbison72	D10210 crecord: null out the curses attribute with `None` on failure to import
Closed	mharbison72	D10209 typing: fix directives mangled by black
Closed	mharbison72	D10208 typing: disable module attribute warnings for properly conditionalized code
Closed	mharbison72	D10207 typing: disable import error warnings that are already handled
Closed	mharbison72	D10206 typing: disable a few errors when accessing Windows specific attributes
Closed	mharbison72	D10205 typing: disable a few errors calling py3.7+ functions in resourceutil.py
Closed	mharbison72	D10204 wsgicgi: switch the default PATH_INFO back to str
Closed	mharbison72	D10203 crecord: convert an instance of bytes to str
Closed	mharbison72	D10202 crecord: change str literals to byte literals
Closed	mharbison72	D10201 bisect: replace a missing method on the list primitive
Closed	mharbison72	D10183 typing: disable a module-attr warning in the worker module's py2 code
Closed	mharbison72	D10182 wireprotoserver: convert ErrorResponse to bytes
Closed	mharbison72	D10181 verify: convert an exception to bytes before logging
Closed	mharbison72	D10180 typing: add an assertion to the upgrade engine to help pytype
Closed	mharbison72	D10179 subrepo: handle unexpected file types from git gracefully
Closed	mharbison72	D10178 patch: convert a UI message to bytes when editing a patch
Closed	mharbison72	D10177 merge: force an exception message to bytes before printing as a warning
Closed	mharbison72	D10176 hg: convert an exception to bytes in the repo creation exception handler
Closed	mharbison72	D10175 typing: add an assertion instead of blacklisting mercurial/extensions.py
Closed	mharbison72	D10174 debug: convert a few exceptions to bytes before wrapping in another error
Closed	mharbison72	D10173 grep: convert an exception to bytes for a warning message
Closed	mharbison72	D10172 morestatus: convert a UI message about merge conflicts to bytes
Closed	mharbison72	D10171 changegroup: convert a warning message to bytes
Closed	mharbison72	D10170 branchmap: force Exception to bytes before logging
Closed	mharbison72	D10169 nodemap: convert error message to bytes
Closed	mharbison72	D10168 mail: convert SMTPException to bytes before passing to error.Abort()
Closed	mharbison72	D10167 typing: switch an argument type to the generic form
Closed	mharbison72	D10166 typing: ensure that error.Abort is given bytes
Closed	mharbison72	D10165 typing: fix a suppression directive that was mangled by black formatting

Diff 26455

mercurial/posix.py

	else:			else:
	# create a fixed file to link to; doesn't matter if it			# create a fixed file to link to; doesn't matter if it
	# already exists.			# already exists.
	target = b'checklink-target'			target = b'checklink-target'
	try:			try:
	fullpath = os.path.join(cachedir, target)			fullpath = os.path.join(cachedir, target)
	open(fullpath, b'w').close()			open(fullpath, b'w').close()
	except IOError as inst:			except IOError as inst:
	if (			# pytype: disable=unsupported-operands
	inst[0] == errno.EACCES			if inst[0] == errno.EACCES:
	): # pytype: disable=unsupported-operands			# pytype: enable=unsupported-operands

	# If we can't write to cachedir, just pretend			# If we can't write to cachedir, just pretend
	# that the fs is readonly and by association			# that the fs is readonly and by association
	# that the fs won't support symlinks. This			# that the fs won't support symlinks. This
	# seems like the least dangerous way to avoid			# seems like the least dangerous way to avoid
	# data loss.			# data loss.
	return False			return False
	raise			raise
	try:			try:

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	26262		Mar 12 2021, 1:08 PM	★	★
Diff 2	26455	rHG6595e22048fe83facc488387b2f87c13f3332dba	Mar 11 2021, 9:21 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

typing: fix a suppression directive that was mangled by black formattingClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 26455

mercurial/posix.py

typing: fix a suppression directive that was mangled by black formatting
ClosedPublic

Revision Contents
Changeset List