( )⚙ D10165 typing: fix a suppression directive that was mangled by black formatting

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10165

typing: fix a suppression directive that was mangled by black formatting
ClosedPublic

Authored by mharbison72 on Mar 12 2021, 1:08 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG6595e22048fe: typing: fix a suppression directive that was mangled by black formatting
Summary

It looks like black is moving comments needed by pytype out of position, and
causing some things that should be disabled to be enforced anyway.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Mar 12 2021, 1:08 PM
mharbison72 added a comment.Mar 12 2021, 1:12 PM

FTR, this stack was built up on default, on top of D7296, D7384, and D7295, as well as a list of exclusions that I added as each run failed. But these seem good for stable, and I didn't want to hold it up to land that stuff.

pulkit accepted this revision.Mar 12 2021, 1:12 PM
This revision is now accepted and ready to land.Mar 12 2021, 1:12 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/posix.py (7 lines)

Diff 26262

mercurial/posix.py

else: else:
# create a fixed file to link to; doesn't matter if it # create a fixed file to link to; doesn't matter if it
# already exists. # already exists.
target = b'checklink-target' target = b'checklink-target'
try: try:
fullpath = os.path.join(cachedir, target) fullpath = os.path.join(cachedir, target)
open(fullpath, b'w').close() open(fullpath, b'w').close()
except IOError as inst: except IOError as inst:
if ( # pytype: disable=unsupported-operands
inst[0] == errno.EACCES if inst[0] == errno.EACCES:
): # pytype: disable=unsupported-operands # pytype: enable=unsupported-operands
# If we can't write to cachedir, just pretend # If we can't write to cachedir, just pretend
# that the fs is readonly and by association # that the fs is readonly and by association
# that the fs won't support symlinks. This # that the fs won't support symlinks. This
# seems like the least dangerous way to avoid # seems like the least dangerous way to avoid
# data loss. # data loss.
return False return False
raise raise
try: try: