commands: necessary annotations and suppresssions to pass pytype
Needs ReviewPublic
Actions

Authored by durin42 on Nov 13 2019, 10:51 PM.

Details

Reviewers

dlax
marmoute

Group Reviewers

hg-reviewers

Summary

As with other places, there are some places where our types are just
too complicated for pytype, so we put some suppressions in place.

Diff Detail

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

durin42 created this revision.Nov 13 2019, 10:51 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptNov 13 2019, 10:51 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

durin42 added a child revision: D7295: pytype: add a (very slow) test that executes pytype.Nov 13 2019, 10:51 PM

dlax added a subscriber: dlax.Nov 14 2019, 4:45 AM

dlax added inline comments.

mercurial/commands.py
1124	This one is sad. I think this can be sorted out by replacing the `try:/finally:` with a context manager. (Can send a patch, if it sounds good to you.)

durin42 added a child revision: D7385: debugcommands: suppress import errors for pytype.Nov 14 2019, 4:10 PM

durin42 removed a child revision: D7295: pytype: add a (very slow) test that executes pytype.

durin42 updated this revision to Diff 18099.

durin42 added inline comments.Nov 14 2019, 4:15 PM

mercurial/commands.py
1124	By all means!

dlax mentioned this in D7430: bisect: replace try:/finally: by a "restore_state" context manager.Nov 15 2019, 5:13 AM

D7430 makes this changes unnecessary I think.

This revision now requires changes to proceed.Nov 15 2019, 6:08 AM

I still want to keep the annotations I added. :)

dlax mentioned this in rHGf37da59a36d9: bisect: replace try:/finally: by a "restore_state" context manager.Nov 15 2019, 12:24 PM

durin42 updated this revision to Diff 18162.Nov 15 2019, 12:31 PM

dlax added inline comments.Nov 15 2019, 12:40 PM

mercurial/commands.py
4746	`revs` is always a `smartset.baseset` per af9c73f26371 so there should be no attribute error. Or is it because `logcmdutil.getlinerangerevs()` has no type annotation (whereas `logcmdutil.getrevs()` has some)?

durin42 updated this revision to Diff 18171.Nov 15 2019, 4:55 PM

durin42 edited parent revisions, added: D7297: cleanup: remove now-obsolete wrong-arg-type annotations; removed: D7383: state: add a pytype annotation.Nov 19 2019, 11:14 AM

durin42 added a child revision: D7295: pytype: add a (very slow) test that executes pytype.

durin42 edited parent revisions, added: D7296: pycompat: kludge around pytype being confused by __new__; removed: D7297: cleanup: remove now-obsolete wrong-arg-type annotations.Nov 19 2019, 1:20 PM

mharbison72 added a child revision: D7515: pytype: [WIP] suppress various warnings inline to get a clean run.Nov 23 2019, 7:47 PM

What's up on this ? It seemed on a good track, but I don't think it landed. @dlax I think you offer to use a context manager got a warm welcome, I would says, go ahead with it.

In D7384#118739, @marmoute wrote:

What's up on this ? It seemed on a good track, but I don't think it landed. @dlax I think you offer to use a context manager got a warm welcome, I would says, go ahead with it.

The context manager got in through D7430.

mercurial/commands.py
4741	I think this comment should be removed since the `# pytype: disable` got removed in the last version of the diff.

There don't seems to be any remaininf feedback on this.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/commands.py (24 lines)

Commit	Parents	Author	Summary	Date
3cc187335754	964681e141a6	Augie Fackler		Nov 13 2019, 10:24 PM

Status	Author	Revision
Closed	durin42	D7406 scmutil: convert status data object from a tuple to an attrs (API)
Closed	durin42	D7405 perf: bool() elements of dirstate.status return instead of len()
Closed	durin42	D7404 tags: use field names instead of field numbers on scmutil.status
Closed	durin42	D7403 subrepo: use field names instead of field numbers on scmutil.status
Closed	durin42	D7402 revset: use field names instead of field numbers on scmutil.status
Closed	durin42	D7401 patch: use field names instead of field numbers on scmutil.status
Closed	durin42	D7400 logcmdutil: use field names instead of field numbers on scmutil.status
Closed	durin42	D7399 context: use field names instead of field numbers on scmutil.status
Closed	durin42	D7398 commands: use field names instead of field numbers on scmutil.status
Closed	durin42	D7397 cmdutil: convert terse status result back to an scmutil.status
Closed	durin42	D7396 cmdutil: use field names instead of field numbers on scmutil.status
Closed	durin42	D7395 uncommit: use field names instead of field numbers on scmutil.status
Closed	durin42	D7394 transplant: use field names instead of field numbers on scmutil.status
Closed	durin42	D7393 split: use field names instead of field numbers on scmutil.status
Closed	durin42	D7392 mq: use field names instead of field numbers on scmutil.status
Closed	durin42	D7391 hgk: use field names instead of field numbers on scmutil.status
Closed	durin42	D7390 extdiff: use field names instead of field numbers on scmutil.status
Closed	durin42	D7294 cmdutil: suppress bogus pytype errors
Closed	durin42	D7293 changegroup: suppress pytype error that's wrong
Closed	durin42	D7292 changegroup: avoid shadowing a set with an int
Closed	durin42	D7291 bundle2: more pytype suppressions around bytestring
Closed	durin42	D7290 branchmap: pytype is confused about bytestr
Closed	durin42	D7410 extensions: suppress a pytype failure due to a typeshed bug
Closed	durin42	D7409 dispatch: add some assertions to give pytype a helping hand
Closed	durin42	D7408 extensions: hide two confusing import statements from pytype
Closed	durin42	D7407 debugcommands: add assertions to convince pytype peer is not None
Closed	durin42	D7385 debugcommands: suppress import errors for pytype
Closed	durin42	D7383 state: add a pytype annotation
Closed	durin42	D7382 logcmdutil: add a type annotation
Closed	durin42	D7381 cmdutil: add a pytype annotation to help out some callsites
Abandoned	durin42	D7297 cleanup: remove now-obsolete wrong-arg-type annotations
Abandoned	durin42	D7380 encoding: define per-use identity functions only in typechecking mode
Changes Planned	mharbison72	D7515 pytype: [WIP] suppress various warnings inline to get a clean run
Needs Review	durin42	D7295 pytype: add a (very slow) test that executes pytype
Needs Review	durin42	D7384 commands: necessary annotations and suppresssions to pass pytype
Changes Planned	durin42	D7296 pycompat: kludge around pytype being confused by __new__
Closed	durin42	D7379 encoding: fix bad type annotation
Closed	durin42	D7389 branchmap: annotate constructor type for branchcache
Closed	durin42	D7378 debugcommands: don't shadow the error module
Closed	durin42	D7289 branchmap: correctly set()-ify list argument

Diff 18171

View Options

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	18071		Nov 13 2019, 10:51 PM	★	★
Diff 2	18099		Nov 14 2019, 4:09 PM	★	★
Diff 3	18162		Nov 15 2019, 12:31 PM	★	★
Diff 4	18171		Nov 15 2019, 4:55 PM	★	★

commands: necessary annotations and suppresssions to pass pytypeNeeds ReviewPublicActions