This is an archive of the discontinued Mercurial Phabricator instance.

changegroup: avoid shadowing a set with an int
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:59 PM.

Details

Summary

This confuses the heck out of pytype, and I basically agree with it
that this shadowing is confusing. There's a chance this causes some
memory to be freed later, but I think it's probably not worth worrying
about for now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 6 2019, 5:59 PM
indygreg accepted this revision.Nov 7 2019, 3:25 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:25 AM
This revision was automatically updated to reflect the committed changes.