This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7405

perf: bool() elements of dirstate.status return instead of len()
ClosedPublic

Authored by durin42 on Nov 14 2019, 4:09 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG6186c2a53ea5: perf: bool() elements of dirstate.status return instead of len()
Summary

I'm about to make scmutil.status no longer have a len(), so we need to do
something else to "use" the results in this perf method.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (2 lines)

Diff 18133

contrib/perf.py

dirstate = repo.dirstate dirstate = repo.dirstate
m = scmutil.matchall(repo) m = scmutil.matchall(repo)
unknown = opts[b'unknown'] unknown = opts[b'unknown']
def status_dirstate(): def status_dirstate():
s = dirstate.status( s = dirstate.status(
m, subrepos=[], ignored=False, clean=False, unknown=unknown m, subrepos=[], ignored=False, clean=False, unknown=unknown
) )
sum(map(len, s)) sum(map(bool, s))
timer(status_dirstate) timer(status_dirstate)
else: else:
timer(lambda: sum(map(len, repo.status(unknown=opts[b'unknown'])))) timer(lambda: sum(map(len, repo.status(unknown=opts[b'unknown']))))
fm.end() fm.end()
@command(b'perfaddremove', formatteropts) @command(b'perfaddremove', formatteropts)