This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7382

logcmdutil: add a type annotation
ClosedPublic

Authored by durin42 on Nov 13 2019, 10:51 PM.

Details

Reviewers
dlax
indygreg
Group Reviewers
hg-reviewers
Commits
rHGc9301ac73b95: logcmdutil: add a type annotation
Summary

This wasn't actually required in the end, as there was a real bug
found by pytype, but the annotation helped me figure that out. We can
drop this patch if that's the preference.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 13 2019, 10:51 PM
dlax accepted this revision.Nov 14 2019, 4:03 AM
durin42 updated this revision to Diff 18098.Nov 14 2019, 4:09 PM
dlax accepted this revision.Nov 15 2019, 3:24 AM
indygreg accepted this revision.Nov 18 2019, 10:43 PM
This revision is now accepted and ready to land.Nov 18 2019, 10:43 PM
durin42 added a commit: rHGc9301ac73b95: logcmdutil: add a type annotation.Nov 18 2019, 10:49 PM
Closed by commit rHGc9301ac73b95: logcmdutil: add a type annotation (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/logcmdutil.py (11 lines)

Diff 18224

mercurial/logcmdutil.py

util, util,
) )
from .utils import ( from .utils import (
dateutil, dateutil,
stringutil, stringutil,
) )
if not globals():
from typing import (
Any,
Tuple,
)
for t in (Any, Tuple):
assert t
def getlimit(opts): def getlimit(opts):
"""get the log limit according to option -l/--limit""" """get the log limit according to option -l/--limit"""
limit = opts.get(b'limit') limit = opts.get(b'limit')
if limit: if limit:
try: try:
limit = int(limit) limit = int(limit)
except ValueError: except ValueError:
raise error.Abort(_(b'limit must be a positive integer')) raise error.Abort(_(b'limit must be a positive integer'))
revs = repo.revs(b'.') revs = repo.revs(b'.')
else: else:
revs = smartset.spanset(repo) revs = smartset.spanset(repo)
revs.reverse() revs.reverse()
return revs return revs
def getrevs(repo, pats, opts): def getrevs(repo, pats, opts):
# type: (Any, Any, Any) -> Tuple[smartset.BaseSet, changesetdiffer]
"""Return (revs, differ) where revs is a smartset """Return (revs, differ) where revs is a smartset
differ is a changesetdiffer with pre-configured file matcher. differ is a changesetdiffer with pre-configured file matcher.
""" """
follow = opts.get(b'follow') or opts.get(b'follow_first') follow = opts.get(b'follow') or opts.get(b'follow_first')
followfirst = opts.get(b'follow_first') followfirst = opts.get(b'follow_first')
limit = getlimit(opts) limit = getlimit(opts)
revs = _initialrevs(repo, opts) revs = _initialrevs(repo, opts)