This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7408

extensions: hide two confusing import statements from pytype
ClosedPublic

Authored by durin42 on Nov 14 2019, 4:10 PM.

Details

Reviewers
dlax
indygreg
Group Reviewers
hg-reviewers
Commits
rHG1ea33dff7841: extensions: hide two confusing import statements from pytype

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 14 2019, 4:10 PM
dlax accepted this revision.Nov 15 2019, 8:31 AM
dlax added a subscriber: dlax.

Out of curiosity, where does this __index__ value come from?

durin42 added a comment.Nov 15 2019, 11:31 AM
In D7408#109174, @dlax wrote:

Out of curiosity, where does this __index__ value come from?

Beats me.

indygreg accepted this revision.Nov 18 2019, 10:45 PM
indygreg added a subscriber: indygreg.

Where does hgext.__index__ come from?!

This revision is now accepted and ready to land.Nov 18 2019, 10:45 PM
dlax added a comment.Nov 19 2019, 2:55 AM
In D7408#109565, @indygreg wrote:

Where does hgext.__index__ come from?!

This is generated by setup.py, apparently only when building with py2exe.

Revision Contents
Changeset List

PathPackages
Mmercurial/extensions.py (4 lines)

Diff 18228

mercurial/extensions.py

return gettext(doc) return gettext(doc)
else: else:
return _(b'(no help text available)') return _(b'(no help text available)')
def disabled(): def disabled():
'''find disabled extensions from hgext. returns a dict of {name: desc}''' '''find disabled extensions from hgext. returns a dict of {name: desc}'''
try: try:
from hgext import __index__ from hgext import __index__ # pytype: disable=import-error
return dict( return dict(
(name, gettext(desc)) (name, gettext(desc))
for name, desc in pycompat.iteritems(__index__.docs) for name, desc in pycompat.iteritems(__index__.docs)
if name not in _order if name not in _order
) )
except (ImportError, AttributeError): except (ImportError, AttributeError):
pass pass
exts[name] = doc.splitlines()[0] exts[name] = doc.splitlines()[0]
return exts return exts
def disabledext(name): def disabledext(name):
'''find a specific disabled extension from hgext. returns desc''' '''find a specific disabled extension from hgext. returns desc'''
try: try:
from hgext import __index__ from hgext import __index__ # pytype: disable=import-error
if name in _order: # enabled if name in _order: # enabled
return return
else: else:
return gettext(__index__.docs.get(name)) return gettext(__index__.docs.get(name))
except (ImportError, AttributeError): except (ImportError, AttributeError):
pass pass