This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7410

extensions: suppress a pytype failure due to a typeshed bug
ClosedPublic

Authored by durin42 on Nov 14 2019, 4:10 PM.

Details

Reviewers
dlax
indygreg
Group Reviewers
hg-reviewers
Commits
rHGda5ccc591cff: extensions: suppress a pytype failure due to a typeshed bug
Summary

Bug filed upstream, suppress the failure here so we can move on.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 14 2019, 4:10 PM
dlax accepted this revision.Nov 15 2019, 9:02 AM
dlax added a subscriber: dlax.
dlax added inline comments.
mercurial/extensions.py
96

the doc indeed says that "fd" is file object

dlax added inline comments.Nov 15 2019, 9:46 AM
mercurial/extensions.py
96

In https://github.com/python/typeshed/blob/master/stdlib/3/imp.pyi type of find_module seems wrong.

durin42 retitled this revision from extensions: suppress a strange pytype failure to extensions: suppress a pytype failure due to a typeshed bug.Nov 15 2019, 11:32 AM
durin42 edited the summary of this revision. (Show Details)
durin42 updated this revision to Diff 18159.
indygreg accepted this revision.Nov 18 2019, 10:46 PM
This revision is now accepted and ready to land.Nov 18 2019, 10:46 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/extensions.py (6 lines)

Diff 18230

mercurial/extensions.py

module_name = module_name.replace(b'.', b'_') module_name = module_name.replace(b'.', b'_')
path = util.normpath(util.expandpath(path)) path = util.normpath(util.expandpath(path))
module_name = pycompat.fsdecode(module_name) module_name = pycompat.fsdecode(module_name)
path = pycompat.fsdecode(path) path = pycompat.fsdecode(path)
if os.path.isdir(path): if os.path.isdir(path):
# module/__init__.py style # module/__init__.py style
d, f = os.path.split(path) d, f = os.path.split(path)
fd, fpath, desc = imp.find_module(f, [d]) fd, fpath, desc = imp.find_module(f, [d])
return imp.load_module(module_name, fd, fpath, desc) # When https://github.com/python/typeshed/issues/3466 is fixed
# and in a pytype release we can drop this disable.
dlaxUnsubmitted
Not Done

the doc indeed says that "fd" is file object

dlax: the doc indeed says that "fd" is file object
dlaxUnsubmitted
Done

In https://github.com/python/typeshed/blob/master/stdlib/3/imp.pyi type of find_module seems wrong.

dlax: In https://github.com/python/typeshed/blob/master/stdlib/3/imp.pyi type of `find_module` seems…
return imp.load_module(
module_name, fd, fpath, desc # pytype: disable=wrong-arg-types
)
else: else:
try: try:
return imp.load_source(module_name, path) return imp.load_source(module_name, path)
except IOError as exc: except IOError as exc:
if not exc.filename: if not exc.filename:
exc.filename = path # python does not fill this exc.filename = path # python does not fill this
raise raise