This is an archive of the discontinued Mercurial Phabricator instance.

durin42 retitled this revision from extensions: suppress a strange pytype failure to extensions: suppress a pytype failure due to a typeshed bug.Nov 15 2019, 11:32 AM

durin42 edited the summary of this revision. (Show Details)

durin42 updated this revision to Diff 18159.

meanwhile, https://github.com/python/typeshed/pull/3465

indygreg accepted this revision.Nov 18 2019, 10:46 PM

This revision is now accepted and ready to land.Nov 18 2019, 10:46 PM

durin42 added a commit: rHGda5ccc591cff: extensions: suppress a pytype failure due to a typeshed bug.Nov 18 2019, 10:51 PM

Closed by commit rHGda5ccc591cff: extensions: suppress a pytype failure due to a typeshed bug (authored by durin42). · Explain Why

This revision was automatically updated to reflect the committed changes.

durin42 removed a child revision: D7295: pytype: add a (very slow) test that executes pytype.Nov 19 2019, 11:14 AM

Revision Contents
Changeset List

			Path	Packages
M			mercurial/extensions.py (6 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	18103		Nov 14 2019, 4:10 PM	★	★
Diff 2	18159		Nov 15 2019, 11:32 AM	★	★
Diff 3	18230	rHGda5ccc591cfff7d2fe421b71be8298ba9e492b25	Nov 15 2019, 11:30 AM	★	★

Commit	Parents	Author	Summary	Date
a39a7d80cb97	7424b53be160	Augie Fackler		Nov 14 2019, 3:55 PM

Status	Author	Revision
Closed	durin42	D7406 scmutil: convert status data object from a tuple to an attrs (API)
Closed	durin42	D7405 perf: bool() elements of dirstate.status return instead of len()
Closed	durin42	D7404 tags: use field names instead of field numbers on scmutil.status
Closed	durin42	D7403 subrepo: use field names instead of field numbers on scmutil.status
Closed	durin42	D7402 revset: use field names instead of field numbers on scmutil.status
Closed	durin42	D7401 patch: use field names instead of field numbers on scmutil.status
Closed	durin42	D7400 logcmdutil: use field names instead of field numbers on scmutil.status
Closed	durin42	D7399 context: use field names instead of field numbers on scmutil.status
Closed	durin42	D7398 commands: use field names instead of field numbers on scmutil.status
Closed	durin42	D7397 cmdutil: convert terse status result back to an scmutil.status
Closed	durin42	D7396 cmdutil: use field names instead of field numbers on scmutil.status
Closed	durin42	D7395 uncommit: use field names instead of field numbers on scmutil.status
Closed	durin42	D7394 transplant: use field names instead of field numbers on scmutil.status
Closed	durin42	D7393 split: use field names instead of field numbers on scmutil.status
Closed	durin42	D7392 mq: use field names instead of field numbers on scmutil.status
Closed	durin42	D7391 hgk: use field names instead of field numbers on scmutil.status
Closed	durin42	D7390 extdiff: use field names instead of field numbers on scmutil.status
Closed	durin42	D7294 cmdutil: suppress bogus pytype errors
Closed	durin42	D7293 changegroup: suppress pytype error that's wrong
Closed	durin42	D7292 changegroup: avoid shadowing a set with an int
Closed	durin42	D7291 bundle2: more pytype suppressions around bytestring
Closed	durin42	D7290 branchmap: pytype is confused about bytestr
Closed	durin42	D7383 state: add a pytype annotation
Closed	durin42	D7382 logcmdutil: add a type annotation
Closed	durin42	D7381 cmdutil: add a pytype annotation to help out some callsites
Abandoned	durin42	D7297 cleanup: remove now-obsolete wrong-arg-type annotations
Abandoned	durin42	D7380 encoding: define per-use identity functions only in typechecking mode
Changes Planned	mharbison72	D7515 pytype: [WIP] suppress various warnings inline to get a clean run
Needs Revision	durin42	D7295 pytype: add a (very slow) test that executes pytype
Closed	durin42	D7410 extensions: suppress a pytype failure due to a typeshed bug
Closed	durin42	D7409 dispatch: add some assertions to give pytype a helping hand
Closed	durin42	D7408 extensions: hide two confusing import statements from pytype
Closed	durin42	D7407 debugcommands: add assertions to convince pytype peer is not None
Closed	durin42	D7385 debugcommands: suppress import errors for pytype
Needs Revision	durin42	D7384 commands: necessary annotations and suppresssions to pass pytype
Changes Planned	durin42	D7296 pycompat: kludge around pytype being confused by __new__
Closed	durin42	D7379 encoding: fix bad type annotation
Closed	durin42	D7389 branchmap: annotate constructor type for branchcache
Closed	durin42	D7378 debugcommands: don't shadow the error module
Closed	durin42	D7289 branchmap: correctly set()-ify list argument

Diff 18103

mercurial/extensions.py

	module_name = module_name.replace(b'.', b'_')			module_name = module_name.replace(b'.', b'_')
	path = util.normpath(util.expandpath(path))			path = util.normpath(util.expandpath(path))
	module_name = pycompat.fsdecode(module_name)			module_name = pycompat.fsdecode(module_name)
	path = pycompat.fsdecode(path)			path = pycompat.fsdecode(path)
	if os.path.isdir(path):			if os.path.isdir(path):
	# module/__init__.py style			# module/__init__.py style
	d, f = os.path.split(path)			d, f = os.path.split(path)
	fd, fpath, desc = imp.find_module(f, [d])			fd, fpath, desc = imp.find_module(f, [d])
	return imp.load_module(module_name, fd, fpath, desc)			# pytype seems to think `fd` is a str, but I'm pretty sure
				# it's wrong. This may be a bug we need to report upstream.
				dlaxUnsubmitted Not Done the doc indeed says that "fd" is file object dlax: the doc indeed says that "fd" is file object
				dlaxUnsubmitted Done In https://github.com/python/typeshed/blob/master/stdlib/3/imp.pyi type of `find_module` seems wrong. dlax: In https://github.com/python/typeshed/blob/master/stdlib/3/imp.pyi type of `find_module` seems…
				return imp.load_module(
				module_name, fd, fpath, desc # pytype: disable=wrong-arg-types
				)
	else:			else:
	try:			try:
	return imp.load_source(module_name, path)			return imp.load_source(module_name, path)
	except IOError as exc:			except IOError as exc:
	if not exc.filename:			if not exc.filename:
	exc.filename = path # python does not fill this			exc.filename = path # python does not fill this
	raise			raise

This is an archive of the discontinued Mercurial Phabricator instance.

extensions: suppress a pytype failure due to a typeshed bugClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18103

mercurial/extensions.py

extensions: suppress a pytype failure due to a typeshed bug
ClosedPublic

Revision Contents
Changeset List