This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7389

branchmap: annotate constructor type for branchcache
ClosedPublic

Authored by durin42 on Nov 14 2019, 4:08 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG9c1eccdd7ed8: branchmap: annotate constructor type for branchcache
Summary

This type signature is...big. But it's correct as far as I can tell,
and it detected a bug.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 14 2019, 4:08 PM
indygreg accepted this revision.Nov 14 2019, 10:17 PM
This revision is now accepted and ready to land.Nov 14 2019, 10:17 PM
durin42 added a commit: rHG9c1eccdd7ed8: branchmap: annotate constructor type for branchcache.Nov 14 2019, 10:36 PM
Closed by commit rHG9c1eccdd7ed8: branchmap: annotate constructor type for branchcache (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (20 lines)

Diff 18116

mercurial/branchmap.py

scmutil, scmutil,
util, util,
) )
from .utils import ( from .utils import (
repoviewutil, repoviewutil,
stringutil, stringutil,
) )
if not globals():
from typing import (
Any,
Callable,
Dict,
Iterable,
List,
Optional,
Set,
Tuple,
Union,
)
assert any(
(Any, Callable, Dict, Iterable, List, Optional, Set, Tuple, Union,)
)
subsettable = repoviewutil.subsettable subsettable = repoviewutil.subsettable
calcsize = struct.calcsize calcsize = struct.calcsize
pack_into = struct.pack_into pack_into = struct.pack_into
unpack_from = struct.unpack_from unpack_from = struct.unpack_from
class BranchMapCache(object): class BranchMapCache(object):
self, self,
entries=(), entries=(),
tipnode=nullid, tipnode=nullid,
tiprev=nullrev, tiprev=nullrev,
filteredhash=None, filteredhash=None,
closednodes=None, closednodes=None,
hasnode=None, hasnode=None,
): ):
# type: (Union[Dict[bytes, List[bytes]], Iterable[Tuple[bytes, List[bytes]]]], bytes, int, Optional[bytes], Optional[Set[bytes]], Optional[Callable[[bytes], bool]]) -> None
""" hasnode is a function which can be used to verify whether changelog """ hasnode is a function which can be used to verify whether changelog
has a given node or not. If it's not provided, we assume that every node has a given node or not. If it's not provided, we assume that every node
we have exists in changelog """ we have exists in changelog """
self.tipnode = tipnode self.tipnode = tipnode
self.tiprev = tiprev self.tiprev = tiprev
self.filteredhash = filteredhash self.filteredhash = filteredhash
# closednodes is a set of nodes that close their branch. If the branch # closednodes is a set of nodes that close their branch. If the branch
# cache has been updated, it may contain nodes that are no longer # cache has been updated, it may contain nodes that are no longer
# heads. # heads.
if closednodes is None: if closednodes is None:
self._closednodes = set() self._closednodes = set()
else: else:
self._closednodes = set(closednodes) self._closednodes = closednodes
self._entries = dict(entries) self._entries = dict(entries)
# whether closed nodes are verified or not # whether closed nodes are verified or not
self._closedverified = False self._closedverified = False
# branches for which nodes are verified # branches for which nodes are verified
self._verifiedbranches = set() self._verifiedbranches = set()
self._hasnode = hasnode self._hasnode = hasnode
if self._hasnode is None: if self._hasnode is None:
self._hasnode = lambda x: True self._hasnode = lambda x: True