( )⚙ D10196 ci: Add a job testing with rhg installed as `hg`

This is an archive of the discontinued Mercurial Phabricator instance.

ci: Add a job testing with rhg installed as `hg`
ClosedPublic

Authored by SimonSapin on Mar 12 2021, 5:08 PM.

Details

Summary

This significantly increases test coverage of rhg, without duplicating
many tests that already exist.

The cargo build command being remove only compiled a rhg executable
(as shown by the preceding cd command) but since a previous patch
run-tests.py --rhg now takes care of that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

SimonSapin created this revision.Mar 12 2021, 5:08 PM
marmoute accepted this revision.Mar 15 2021, 6:02 AM
marmoute added a subscriber: marmoute.

Great !

Alphare requested changes to this revision.Mar 15 2021, 6:50 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
contrib/heptapod-ci.yml
30

Isn't that unrelated? AFAIU, this (without the explicit rhg step) is still needed for both Python+C+Rust variants.

This revision now requires changes to proceed.Mar 15 2021, 6:50 AM
marmoute requested changes to this revision.Mar 15 2021, 7:40 AM
marmoute added inline comments.
contrib/heptapod-ci.yml
30

+1, we need to keep the --rust testing too.

SimonSapin added inline comments.Mar 15 2021, 7:49 AM
contrib/heptapod-ci.yml
30

run-tests.py --rust is still working: https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/175900#L44

It’s been capable for a long time now to tell make/setuptools to enable the Rust-based extension module for Python. This separate cargo build command was only compiling the rhg executable (as shown by the cd command), but previous patches in this series made run-tests.py/make take care of that too.

Alphare accepted this revision.Mar 15 2021, 7:50 AM

Cool, thanks!

marmoute accepted this revision.Mar 15 2021, 7:52 AM

Can you highlight this in your commit message ?

This revision now requires review to proceed.Mar 15 2021, 7:52 AM
baymax edited the summary of this revision. (Show Details)Mar 15 2021, 9:10 AM
baymax updated this revision to Diff 26359.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Mar 15 2021, 9:57 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

that seems a great idea as something has been brought up for new grads. Many have complains about other companies but now that complains have been reduced with the help of a new amazon jobs philadelphia. They are the best and affordable in the town.