( )⚙ D1021 check-code: forbid platform.system()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1021

check-code: forbid platform.system()
ClosedPublic

Authored by quark on Oct 11 2017, 8:57 PM.

Details

Reviewers
lothiraldan
Group Reviewers
hg-reviewers
Commits
rHGa679aa582d8d: check-code: forbid platform.system()
Summary

See the previous patches for the reason.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Oct 11 2017, 8:57 PM
lothiraldan accepted this revision.Oct 12 2017, 5:08 AM
lothiraldan added a subscriber: lothiraldan.

LGTM but I can't validate the Mac OS and Windows tests.

ryanmce added a subscriber: ryanmce.Oct 12 2017, 10:57 AM

+1 to this change, happy to land this once my comments on the series are addressed

quark updated this revision to Diff 2634.Oct 12 2017, 12:37 PM
Closed by commit rHGa679aa582d8d: check-code: forbid platform.system() (authored by quark). · Explain WhyOct 13 2017, 10:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (1 line)

Diff 2608

contrib/check-code.py

(r'^import pickle', "don't use pickle, use util.pickle"), (r'^import pickle', "don't use pickle, use util.pickle"),
(r'^import httplib', "don't use httplib, use util.httplib"), (r'^import httplib', "don't use httplib, use util.httplib"),
(r'^import BaseHTTPServer', "use util.httpserver instead"), (r'^import BaseHTTPServer', "use util.httpserver instead"),
(r'^(from|import) mercurial\.(cext|pure|cffi)', (r'^(from|import) mercurial\.(cext|pure|cffi)',
"use mercurial.policy.importmod instead"), "use mercurial.policy.importmod instead"),
(r'\.next\(\)', "don't use .next(), use next(...)"), (r'\.next\(\)', "don't use .next(), use next(...)"),
(r'([a-z]*).revision\(\1\.node\(', (r'([a-z]*).revision\(\1\.node\(',
"don't convert rev to node before passing to revision(nodeorrev)"), "don't convert rev to node before passing to revision(nodeorrev)"),
(r'platform\.system()', "don't use platform.system(), use pycompat"),
# rules depending on implementation of repquote() # rules depending on implementation of repquote()
(r' x+[xpqo%APM][\'"]\n\s+[\'"]x', (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',
'string join across lines with no space'), 'string join across lines with no space'),
(r'''(?x)ui\.(status|progress|write|note|warn)\( (r'''(?x)ui\.(status|progress|write|note|warn)\(
[ \t\n#]* [ \t\n#]*
(?# any strings/comments might precede a string, which (?# any strings/comments might precede a string, which
# contains translatable message) # contains translatable message)