( )⚙ D1023 sparse: don't crash in non-sparse repositories

This is an archive of the discontinued Mercurial Phabricator instance.

sparse: don't crash in non-sparse repositories
ClosedPublic

Authored by simpkins on Oct 11 2017, 9:20 PM.
Tags
None
Subscribers
None

Details

Reviewers
mbthomas
Group Reviewers
Restricted Project
Commits
rFBHGX01acc01a2120: sparse: don't crash in non-sparse repositories
Summary

Update the workingfilectxdata() to check that this is actually a sparse
repository before trying to call repo.sparsematch()

Test Plan

Update the test to confirm that "hg diff" works instead of crashes now.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

simpkins created this revision.Oct 11 2017, 9:20 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2017, 9:20 PM
mbthomas accepted this revision.Oct 12 2017, 7:40 AM
This revision is now accepted and ready to land.Oct 12 2017, 7:40 AM
This revision was automatically updated to reflect the committed changes.