Page MenuHomePhabricator

typing: make minor adjustments to mercurial/util.py to pass pytype checking
ClosedPublic

Authored by mharbison72 on Mar 26 2021, 12:39 AM.

Details

Summary

I'm assuming the wrong-arg-count is a pytype bug, because this code is used by
the config object. Avoiding initializing _lrucachenode node points to None
eliminates a few is not None assertions, but apparently not all of them. I
can't figure out why it gets confused over the state where these new assertions
are.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Mar 26 2021, 12:39 AM
pulkit accepted this revision.Apr 11 2021, 5:28 PM
This revision is now accepted and ready to land.Apr 11 2021, 5:28 PM