This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10275

util: fix the signature for the pypy override of sortdict.update()
ClosedPublic

Authored by mharbison72 on Mar 26 2021, 12:39 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG64400d05db1e: util: fix the signature for the pypy override of sortdict.update()
Summary

PyCharm flagged this as not matching the base class signature. Not sure if
there was anything supplying these extra arguments though.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (4 lines)

Diff 26812

mercurial/util.py

def __setitem__(self, key, value): def __setitem__(self, key, value):
if key in self: if key in self:
del self[key] del self[key]
super(sortdict, self).__setitem__(key, value) super(sortdict, self).__setitem__(key, value)
if pycompat.ispypy: if pycompat.ispypy:
# __setitem__() isn't called as of PyPy 5.8.0 # __setitem__() isn't called as of PyPy 5.8.0
def update(self, src): def update(self, src, **f):
if isinstance(src, dict): if isinstance(src, dict):
src = pycompat.iteritems(src) src = pycompat.iteritems(src)
for k, v in src: for k, v in src:
self[k] = v self[k] = v
for k in f:
self[k] = f[k]
def insert(self, position, key, value): def insert(self, position, key, value):
for (i, (k, v)) in enumerate(list(self.items())): for (i, (k, v)) in enumerate(list(self.items())):
if i == position: if i == position:
self[key] = value self[key] = value
if i >= position: if i >= position:
del self[k] del self[k]
self[k] = v self[k] = v