( )⚙ D10283 copies: simplify

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10283

copies: simplify
AbandonedPublic

Authored by joerg.sonnenberger on Mar 28 2021, 6:38 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

durin42 added a subscriber: durin42.Mar 29 2021, 3:29 PM

So, I've gone through several of these now, and I realize: why are we moving towards revs and away from nodes? That's the opposite of the refactor I'd expect...

Revision Contents
Changeset List

PathPackages
Mmercurial/copies.py (2 lines)

Diff 26615

mercurial/copies.py

# Computing the forward missing is quite expensive on large manifests, since # Computing the forward missing is quite expensive on large manifests, since
# it compares the entire manifests. We can optimize it in the common use # it compares the entire manifests. We can optimize it in the common use
# case of computing what copies are in a commit versus its parent (like # case of computing what copies are in a commit versus its parent (like
# during a rebase or histedit). Note, we exclude merge commits from this # during a rebase or histedit). Note, we exclude merge commits from this
# optimization, since the ctx.files() for a merge commit is not correct for # optimization, since the ctx.files() for a merge commit is not correct for
# this comparison. # this comparison.
forwardmissingmatch = match forwardmissingmatch = match
if b.p1() == a and b.p2().node() == nullid: if b.p1() == a and b.p2().rev() == nullrev:
filesmatcher = matchmod.exact(b.files()) filesmatcher = matchmod.exact(b.files())
forwardmissingmatch = matchmod.intersectmatchers(match, filesmatcher) forwardmissingmatch = matchmod.intersectmatchers(match, filesmatcher)
if repo.ui.configbool(b'devel', b'copy-tracing.trace-all-files'): if repo.ui.configbool(b'devel', b'copy-tracing.trace-all-files'):
missing = list(b.walk(match)) missing = list(b.walk(match))
# _computeforwardmissing(a, b, match=forwardmissingmatch) # _computeforwardmissing(a, b, match=forwardmissingmatch)
if debug: if debug:
dbg(b'debug.copies: searching all files: %d\n' % len(missing)) dbg(b'debug.copies: searching all files: %d\n' % len(missing))
else: else: