This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10289

setdiscovery: simplify by using tiprev directly
ClosedPublic

Authored by joerg.sonnenberger on Mar 29 2021, 8:16 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGe7b4607d52e3: setdiscovery: simplify by using tiprev directly
Summary

tip() uses tiprev() and reads the node from it, so drop a layer of
indirection.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joerg.sonnenberger added a commit: rHGe7b4607d52e3: setdiscovery: simplify by using tiprev directly.Mar 30 2021, 4:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGe7b4607d52e3: setdiscovery: simplify by using tiprev directly (authored by joerg.sonnenberger). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/setdiscovery.py (2 lines)

Diff 26631

mercurial/setdiscovery.py

}, },
) )
srvheadhashes, yesno = fheads.result(), fknown.result() srvheadhashes, yesno = fheads.result(), fknown.result()
if audit is not None: if audit is not None:
audit[b'total-roundtrips'] = 1 audit[b'total-roundtrips'] = 1
if cl.tip() == nullid: if cl.tiprev() == nullrev:
if srvheadhashes != [nullid]: if srvheadhashes != [nullid]:
return [nullid], True, srvheadhashes return [nullid], True, srvheadhashes
return [nullid], False, [] return [nullid], False, []
else: else:
# we still need the remote head for the function return # we still need the remote head for the function return
with remote.commandexecutor() as e: with remote.commandexecutor() as e:
fheads = e.callcommand(b'heads', {}) fheads = e.callcommand(b'heads', {})
srvheadhashes = fheads.result() srvheadhashes = fheads.result()