Page MenuHomePhabricator

refactor: prefer lookup by revision, even for null
ClosedPublic

Authored by joerg.sonnenberger on Mar 28 2021, 5:11 PM.

Details

Summary

While the nullid lookup is a special case, it is still more complicated.
The common pattern is to lookup via nullrev so be consistent here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joerg.sonnenberger retitled this revision from cmdutil: simplify to cmdutil: prefer lookup by revision, even for null.Mar 29 2021, 8:25 PM
joerg.sonnenberger edited the summary of this revision. (Show Details)
joerg.sonnenberger retitled this revision from cmdutil: prefer lookup by revision, even for null to refactor: prefer lookup by revision, even for null.Mar 29 2021, 8:33 PM
joerg.sonnenberger updated this revision to Diff 26627.
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.