Differential D9465

[POC] node: replace nullid and friends with nodeconstants class
Needs ReviewPublic
Actions

Authored by joerg.sonnenberger on Nov 30 2020, 6:23 AM.

Tags

None

Subscribers

Kwan, mercurial-patches

Details

Reviewers

indygreg
durin42
martinvonz

Group Reviewers

Summary

The introduction of 256bit hashes require changes to nullid and other
constant magic values. Start pushing them down from repository and
revlog where sensible.

Diff Detail

Repository

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

joerg.sonnenberger created this revision.Nov 30 2020, 6:23 AM

Herald added a reviewer: indygreg. · View Herald TranscriptNov 30 2020, 6:23 AM

Herald added a reviewer: durin42. · View Herald Transcript

Herald added a reviewer: durin42. · View Herald Transcript

Herald added a reviewer: martinvonz. · View Herald Transcript

Herald added a reviewer: martinvonz. · View Herald Transcript

Herald added a reviewer: hg-reviewers. · View Herald Transcript

Herald added subscribers: mercurial-patches, Kwan. · View Herald Transcript

joerg.sonnenberger updated this revision to Diff 24306.Dec 16 2020, 8:12 AM

joerg.sonnenberger mentioned this in D9750: node: introduce nodeconstants class.Wed, Jan 13, 10:56 AM

Large Diff

This large diff affects 110 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

			Path	Packages
M			contrib/perf.py (2 lines)
M			hgext/absorb.py (10 lines)
M			hgext/convert/git.py (14 lines)
M			hgext/convert/hg.py (15 lines)
M			hgext/extdiff.py (6 lines)
M			hgext/fix.py (6 lines)
M			hgext/git/dirstate.py (14 lines)
M			hgext/git/gitlog.py (40 lines)
M			hgext/git/gitutil.py (4 lines)
M			hgext/git/index.py (11 lines)
M			hgext/gpg.py (5 lines)
M			hgext/hgk.py (7 lines)
M			hgext/infinitepush/store.py (1 line)
M			hgext/journal.py (7 lines)
M			hgext/largefiles/basestore.py (6 lines)
M			hgext/largefiles/lfcommands.py (7 lines)
M			hgext/largefiles/lfutil.py (8 lines)
M			hgext/lfs/wrapper.py (4 lines)
M			hgext/mq.py (9 lines)
M			hgext/narrow/narrowbundle2.py (5 lines)
M			hgext/narrow/narrowcommands.py (7 lines)
M			hgext/patchbomb.py (1 line)
M			hgext/phabricator.py (6 lines)
M			hgext/releasenotes.py (1 line)
M			hgext/remotefilelog/basepack.py (1 line)
M			hgext/remotefilelog/contentstore.py (35 lines)
M			hgext/remotefilelog/datapack.py (7 lines)
M			hgext/remotefilelog/debugcommands.py (16 lines)
M			hgext/remotefilelog/fileserverclient.py (10 lines)
M			hgext/remotefilelog/historypack.py (13 lines)
M			hgext/remotefilelog/metadatastore.py (9 lines)
M			hgext/remotefilelog/remotefilectx.py (20 lines)
M			hgext/remotefilelog/remotefilelog.py (48 lines)
M			hgext/remotefilelog/remotefilelogserver.py (14 lines)
M			hgext/remotefilelog/repack.py (27 lines)
M			hgext/remotefilelog/shallowbundle.py (10 lines)
M			hgext/remotefilelog/shallowrepo.py (6 lines)
M			hgext/split.py (8 lines)
M			hgext/sqlitestore.py (51 lines)
M			hgext/transplant.py (15 lines)
M			hgext/uncommit.py (3 lines)
M			mercurial/bookmarks.py (9 lines)
M			mercurial/branchmap.py (17 lines)
M			mercurial/bundle2.py (7 lines)
M			mercurial/bundlerepo.py (20 lines)
M			mercurial/changegroup.py (17 lines)
M			mercurial/changelog.py (11 lines)
M			mercurial/cmdutil.py (22 lines)
M			mercurial/commands.py (26 lines)
M			mercurial/commit.py (40 lines)
M			mercurial/context.py (66 lines)
M			mercurial/copies.py (9 lines)
M			mercurial/debugcommands.py (13 lines)
M			mercurial/dirstate.py (48 lines)
M			mercurial/discovery.py (16 lines)
M			mercurial/exchange.py (15 lines)
M			mercurial/exchangev2.py (15 lines)
M			mercurial/filelog.py (8 lines)
M			mercurial/filemerge.py (3 lines)
M			mercurial/hg.py (15 lines)
M			mercurial/hgweb/webutil.py (12 lines)
M			mercurial/interfaces/dirstate.py (6 lines)
M			mercurial/interfaces/repository.py (19 lines)
M			mercurial/localrepo.py (35 lines)
M			mercurial/logcmdutil.py (16 lines)
M			mercurial/manifest.py (90 lines)
M			mercurial/merge.py (21 lines)
M			mercurial/mergestate.py (15 lines)
M			mercurial/metadata.py (7 lines)
M			mercurial/node.py (54 lines)
M			mercurial/obsolete.py (18 lines)
M			mercurial/phases.py (7 lines)
M			mercurial/pure/parsers.py (9 lines)
M			mercurial/revlog.py (62 lines)
M			mercurial/scmutil.py (8 lines)
M			mercurial/setdiscovery.py (21 lines)
M			mercurial/shelve.py (9 lines)
M			mercurial/simplemerge.py (4 lines)
M			mercurial/sparse.py (9 lines)
M			mercurial/statichttprepo.py (5 lines)
M			mercurial/store.py (2 lines)
M			mercurial/strip.py (5 lines)
M			mercurial/subrepo.py (3 lines)
M			mercurial/tagmerge.py (7 lines)
M			mercurial/tags.py (23 lines)
M			mercurial/templatefuncs.py (7 lines)
M			mercurial/templatekw.py (9 lines)
M			mercurial/testing/storage.py (263 lines)
M			mercurial/thirdparty/selectors2.py (118 lines)
M			mercurial/treediscovery.py (19 lines)
M			mercurial/unionrepo.py (11 lines)
M			mercurial/upgrade_utils/engine.py (4 lines)
M			mercurial/util.py (1 line)
M			mercurial/utils/storageutil.py (8 lines)
M			mercurial/verify.py (13 lines)
M			mercurial/wireprotov1server.py (7 lines)
M			mercurial/wireprotov2server.py (7 lines)
M			tests/drawdag.py (5 lines)
M			tests/simplestorerepo.py (35 lines)
M			tests/test-annotate.t (8 lines)
M			tests/test-check-interfaces.py (7 lines)
M			tests/test-commit.t (12 lines)
M			tests/test-fastannotate-hg.t (8 lines)
M			tests/test-filelog.py (9 lines)
M			tests/test-manifest.py (4 lines)
M			tests/test-parseindex2.py (8 lines)
M			tests/test-remotefilelog-datapack.py (40 lines)
M			tests/test-remotefilelog-histpack.py (49 lines)
M			tests/test-revlog-raw.py (9 lines)
M			tests/testlib/ext-sidedata.py (7 lines)

Diff 24306

contrib/perf.py

hgext/absorb.py

hgext/convert/git.py

hgext/convert/hg.py

hgext/extdiff.py

hgext/fix.py

hgext/git/dirstate.py

hgext/git/gitlog.py

hgext/git/gitutil.py

hgext/git/index.py

hgext/gpg.py

hgext/hgk.py

hgext/infinitepush/store.py

hgext/journal.py

hgext/largefiles/basestore.py

hgext/largefiles/lfcommands.py

hgext/largefiles/lfutil.py

hgext/lfs/wrapper.py

hgext/mq.py

hgext/narrow/narrowbundle2.py

hgext/narrow/narrowcommands.py

hgext/patchbomb.py

hgext/phabricator.py

hgext/releasenotes.py

hgext/remotefilelog/basepack.py

hgext/remotefilelog/contentstore.py

hgext/remotefilelog/datapack.py

hgext/remotefilelog/debugcommands.py

hgext/remotefilelog/fileserverclient.py

hgext/remotefilelog/historypack.py

hgext/remotefilelog/metadatastore.py

hgext/remotefilelog/remotefilectx.py

hgext/remotefilelog/remotefilelog.py

hgext/remotefilelog/remotefilelogserver.py

hgext/remotefilelog/repack.py

hgext/remotefilelog/shallowbundle.py

hgext/remotefilelog/shallowrepo.py

hgext/split.py

hgext/sqlitestore.py

hgext/transplant.py

hgext/uncommit.py

mercurial/bookmarks.py

mercurial/branchmap.py

mercurial/bundle2.py

mercurial/bundlerepo.py

mercurial/changegroup.py

mercurial/changelog.py

mercurial/cmdutil.py

mercurial/commands.py

mercurial/commit.py

mercurial/context.py

mercurial/copies.py

mercurial/debugcommands.py

mercurial/dirstate.py

mercurial/discovery.py

mercurial/exchange.py

mercurial/exchangev2.py

mercurial/filelog.py

mercurial/filemerge.py

mercurial/hg.py

mercurial/hgweb/webutil.py

mercurial/interfaces/dirstate.py

mercurial/interfaces/repository.py

mercurial/localrepo.py

mercurial/logcmdutil.py

mercurial/manifest.py

mercurial/merge.py

mercurial/mergestate.py

mercurial/metadata.py

mercurial/node.py

mercurial/obsolete.py

mercurial/phases.py

mercurial/pure/parsers.py

mercurial/revlog.py

mercurial/scmutil.py

mercurial/setdiscovery.py

mercurial/shelve.py

mercurial/simplemerge.py

mercurial/sparse.py

mercurial/statichttprepo.py

mercurial/store.py

mercurial/strip.py

mercurial/subrepo.py

mercurial/tagmerge.py

mercurial/tags.py

mercurial/templatefuncs.py

mercurial/templatekw.py

mercurial/testing/storage.py

mercurial/thirdparty/selectors2.py

mercurial/treediscovery.py

mercurial/unionrepo.py

mercurial/upgrade_utils/engine.py

mercurial/util.py

mercurial/utils/storageutil.py

mercurial/verify.py

mercurial/wireprotov1server.py

mercurial/wireprotov2server.py

tests/drawdag.py

tests/simplestorerepo.py

tests/test-annotate.t

tests/test-check-interfaces.py

tests/test-commit.t

tests/test-fastannotate-hg.t

tests/test-filelog.py

tests/test-manifest.py

tests/test-parseindex2.py

tests/test-remotefilelog-datapack.py

tests/test-remotefilelog-histpack.py

tests/test-revlog-raw.py

tests/testlib/ext-sidedata.py