( )⚙ D10332 persistent-nodemap: disable it unconditionally for test-http-protocol.t

This is an archive of the discontinued Mercurial Phabricator instance.

persistent-nodemap: disable it unconditionally for test-http-protocol.t
ClosedPublic

Authored by marmoute on Apr 8 2021, 11:34 PM.

Details

Summary

This is not relevant for the test and this will avoid a lot of variations.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 8 2021, 11:34 PM
Alphare accepted this revision.Apr 9 2021, 3:58 AM
baymax updated this revision to Diff 26761.Apr 9 2021, 5:27 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit added a subscriber: pulkit.Apr 9 2021, 6:29 AM
pulkit added inline comments.
tests/test-http-protocol.t
3

This sentence confuses me. The test is disabling it right?

marmoute added inline comments.Apr 9 2021, 6:38 AM
tests/test-http-protocol.t
3

The new code make sure it stay disabled. The end of the series enable it by default for rust build, we want to keep it off in some tests (where it does not make a different and introduce a LOT of noise)

pulkit added inline comments.Apr 9 2021, 1:00 PM
tests/test-http-protocol.t
3

Okay seems like it's a different understanding of English which confused me. Re-reading few times I can understand what you meant.

pulkit accepted this revision.Apr 11 2021, 5:30 PM
This revision is now accepted and ready to land.Apr 11 2021, 5:30 PM