( )⚙ D10394 run-test: make it clearer why we terminating process

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10394

run-test: make it clearer why we terminating process
ClosedPublic

Authored by marmoute on Apr 14 2021, 10:46 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG248cbe173203: run-test: make it clearer why we terminating process
Summary

The --verbose log wer only talking about process termination. Now we have more
information about why.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 14 2021, 10:46 AM
pulkit accepted this revision.Apr 14 2021, 7:50 PM
This revision is now accepted and ready to land.Apr 14 2021, 7:50 PM
marmoute added a commit: rHG248cbe173203: run-test: make it clearer why we terminating process.Apr 14 2021, 8:40 PM
Closed by commit rHG248cbe173203: run-test: make it clearer why we terminating process (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (1 line)

Diff 26850

tests/run-tests.py

p.timeout = False p.timeout = False
if timeout: if timeout:
def t(): def t():
start = time.time() start = time.time()
while time.time() - start < timeout and p.returncode is None: while time.time() - start < timeout and p.returncode is None:
time.sleep(0.1) time.sleep(0.1)
p.timeout = True p.timeout = True
vlog('# Timout reached for process %d' % p.pid)
if p.returncode is None: if p.returncode is None:
terminate(p) terminate(p)
threading.Thread(target=t).start() threading.Thread(target=t).start()
return p return p