This is an archive of the discontinued Mercurial Phabricator instance.

tersestatus: avoid modifying tersedict
ClosedPublic

Authored by pulkit on Oct 12 2017, 7:56 PM.

Details

Summary

Turn dirnode's methods into generators which can be used to update "tersedict"
in caller. So instead of passing the "tersedict" to be mutated here and there,
it's now clearer where it is updated as it's purely a local variable to
tersedir() function.

While I was here, I renamed _processtersestatus to tersewalk and
_addfilestotersed to iterfilepaths.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 12 2017, 7:56 PM
durin42 accepted this revision.Oct 14 2017, 12:47 AM
This revision is now accepted and ready to land.Oct 14 2017, 12:47 AM
This revision was automatically updated to reflect the committed changes.